feature: @putout/plugin-printer: add-missing-tuple-to-type-checker: add

Author: coderaiser

packages/plugin-printer/README.md

@@ -15,6 +15,7 @@ npm i @putout/plugin-printer -D
 
 - ✅ [add-args](#add-args);
 - ✅ [add-missing-spacess-to-type-checker](#add-missing-spacess-to-type-checker);
+- ✅ [add-missing-tuple-to-type-checker](#add-missing-tuple-to-type-checker);
 - ✅ [apply-breakline](#apply-breakline);
 - ✅ [apply-computed-print](#apply-computed-print);
 - ✅ [apply-create-test-url](#apply-create-test-url);
@@ -34,7 +35,7 @@ npm i @putout/plugin-printer -D
 {
     "rules": {
         "printer/add-args": "on",
-        "printer/add-missing-spacess-to-type-checker": "on",
+        "printer/add-missing-tuple-to-type-checker": "on",
         "printer/apply-breakline": "on",
         "printer/apply-linebreak": "on",
         "printer/apply-computed-print": "on",
@@ -124,6 +125,34 @@ export const beforeIf = createTypeChecker([
 ]);
 ```
 
+## add-missing-tuple-to-type-checker
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/9fdfda423df3af9b0f08541710706299/0259bba117997861fe7573bad5477282f4df8554).
+
+### ❌ Example of incorrect code
+
+```js
+export const beforeIf = createTypeChecker([
+    '- : -> !StringLiteral',
+    '- : -> BlockStatement',
+    '- : -> WrongType',
+    ['- : ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+```
+
+### ✅ Example of correct code
+
+```js
+export const beforeIf = createTypeChecker([
+    ['- : -> !StringLiteral'],
+    ['- : -> BlockStatement'],
+    ['- : -> WrongType'],
+    ['- : ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+```
+
 ## apply-computed-print
 
 ### ❌ Example of incorrect code

packages/plugin-printer/lib/add-missing-tuples-to-type-checker/fixture/add-missing-tuples-to-type-checker-fix.js

@@ -0,0 +1,21 @@
+export const beforeIf = createTypeChecker([
+    ['- : -> !StringLiteral'],
+    ['- : -> BlockStatement'],
+    ['- : -> WrongType'],
+    ['- : ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+
+export const allTuples = createTypeChecker([
+    ['- : ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+
+export const allStrings = createTypeChecker([
+    '- : -> BlockStatement',
+    '- : -> WrongType',
+]);
+
+export const allIdentifiers = createTypeChecker([
+    isExpressionStatement,
+]);

packages/plugin-printer/lib/add-missing-tuples-to-type-checker/fixture/add-missing-tuples-to-type-checker.js

@@ -0,0 +1,21 @@
+export const beforeIf = createTypeChecker([
+    '- : -> !StringLiteral',
+    '- : -> BlockStatement',
+    '- : -> WrongType',
+    ['- : ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+
+export const allTuples = createTypeChecker([
+    ['- : ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+
+export const allStrings = createTypeChecker([
+    '- : -> BlockStatement',
+    '- : -> WrongType',
+]);
+
+export const allIdentifiers = createTypeChecker([
+    isExpressionStatement,
+]);

packages/plugin-printer/lib/add-missing-tuples-to-type-checker/index.js

@@ -0,0 +1,57 @@
+import {operator, types} from 'putout';
+
+const {
+    isStringLiteral,
+    isArrayExpression,
+    isIdentifier,
+    isCallExpression,
+    arrayExpression,
+} = types;
+
+const {replaceWith} = operator;
+
+export const report = (path) => {
+    return `Add missing tuple around: ${path}`;
+};
+
+export const fix = (path) => {
+    replaceWith(path, arrayExpression([path.node]));
+};
+
+export const traverse = ({push}) => ({
+    ArrayExpression(path) {
+        const {parentPath} = path;
+        
+        if (!isCallExpression(parentPath))
+            return;
+        
+        if (!isIdentifier(parentPath.node.callee, {name: 'createTypeChecker'}))
+            return;
+        
+        const elements = path.get('elements');
+        
+        if (isConsistent(elements))
+            return;
+        
+        for (const element of elements) {
+            if (!isArrayExpression(element))
+                push(element);
+        }
+    },
+});
+
+function isConsistent(elements) {
+    const arraysCount = elements.filter(isArrayExpression).length;
+    
+    if (elements.length === arraysCount)
+        return true;
+    
+    const stringsCount = elements.filter(isStringLiteral).length;
+    
+    if (elements.length === stringsCount)
+        return true;
+    
+    const identifiersCount = elements.filter(isIdentifier).length;
+    
+    return elements.length === identifiersCount;
+}

packages/plugin-printer/lib/add-missing-tuples-to-type-checker/index.spec.js

@@ -0,0 +1,18 @@
+import {createTest} from '@putout/test';
+import * as plugin from './index.js';
+
+const test = createTest(import.meta.url, {
+    plugins: [
+        ['add-missing-tuples-to-type-checker', plugin],
+    ],
+});
+
+test('printer: add-missing-tuples-to-type-checker: report', (t) => {
+    t.report('add-missing-tuples-to-type-checker', `Add missing tuple around: '- : -> !StringLiteral'`);
+    t.end();
+});
+
+test('printer: add-missing-tuples-to-type-checker: transform', (t) => {
+    t.transform('add-missing-tuples-to-type-checker');
+    t.end();
+});

packages/plugin-printer/lib/index.js

@@ -1,3 +1,4 @@
+import * as addMissingTuplesToTypeChecker from './add-missing-tuples-to-type-checker/index.js';
 import * as checkTypePassedToTypeChecker from './check-type-passed-to-type-checker/index.js';
 import * as removeUselessSpacesFromTypeChecker from './remove-useless-spaces-from-type-checker/index.js';
 import * as addMissingSpacesToTypeChecker from './add-missing-spaces-to-type-checker/index.js';
@@ -28,4 +29,5 @@ export const rules = {
     'add-missing-spaces-to-type-checker': addMissingSpacesToTypeChecker,
     'remove-useless-spaces-from-type-checker': removeUselessSpacesFromTypeChecker,
     'check-type-passed-to-type-checker': checkTypePassedToTypeChecker,
+    'add-missing-tuples-to-type-checker': addMissingTuplesToTypeChecker,
 };

packages/plugin-printer/test/fixture/add-missing-spaces-to-type-checker-fix.js

@@ -1,6 +1,6 @@
 export const beforeIf = createTypeChecker([
     ['-: -> !', isInsideArray],
     ['-: parentPath ->', isCoupleLines],
-    isIdentifierAndIdentifier,
-    isStringAndIdentifierInsideOneElementArray,
+    [isIdentifierAndIdentifier],
+    [isStringAndIdentifierInsideOneElementArray],
 ]);

packages/plugin-printer/test/fixture/add-missing-tuples-to-type-checker-fix.js

@@ -0,0 +1,26 @@
+import {types} from '@putout/babel';
+
+const {isExpressionStatement} = types;
+const {isBlockStatement} = types;
+
+export const beforeIf = createTypeChecker([
+    ['-: -> !StringLiteral'],
+    ['-: -> BlockStatement'],
+    ['-: -> 🧨 WrongType'],
+    ['-: ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+
+export const allTuples = createTypeChecker([
+    ['-: ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+
+export const allStrings = createTypeChecker([
+    '-: -> BlockStatement',
+    '-: -> 🧨 WrongType',
+]);
+
+export const allIdentifiers = createTypeChecker([
+    isExpressionStatement,
+]);

packages/plugin-printer/test/fixture/add-missing-tuples-to-type-checker.js

@@ -0,0 +1,21 @@
+export const beforeIf = createTypeChecker([
+    '- : -> !StringLiteral',
+    '- : -> BlockStatement',
+    '- : -> WrongType',
+    ['- : ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+
+export const allTuples = createTypeChecker([
+    ['- : ->', isBlockStatement],
+    ['-', isBlockStatement],
+]);
+
+export const allStrings = createTypeChecker([
+    '- : -> BlockStatement',
+    '- : -> WrongType',
+]);
+
+export const allIdentifiers = createTypeChecker([
+    isExpressionStatement,
+]);

packages/plugin-printer/test/fixture/check-type-passed-to-type-checker-fix.js

@@ -3,7 +3,7 @@ import {types} from '@putout/babel';
 const {isBlockStatement} = types;
 
 export const beforeIf = createTypeChecker([
-    '-: -> !StringLiteral',
+    ['-: -> !StringLiteral'],
     ['-: -> BlockStatement'],
     ['-: -> 🧨 WrongType'],
     ['-: ->', isBlockStatement],