feature: @putout/plugin-printer: remove-useless-not-from-type-checker

Author: coderaiser

packages/plugin-printer/README.md

@@ -29,10 +29,11 @@ npm i @putout/plugin-printer -D
 - ✅ [remove-args](#remove-args);
 - ✅ [remove-useless-maybe](#remove-useless-maybe);
 - ✅ [remove-legacy-test-declaration](#remove-legacy-test-declaration);
-- ✅ [remove-trailing-spaces-from-type-checker](#remove-trailing-spaces-from-type-checker)
-- ✅ [remove-useless-spaces-from-type-checker](#remove-useless-spaces-from-type-checker)
-- ✅ [remove-useless-colon-from-type-checker](#remove-useless-colon-from-type-checker)
-- ✅ [remove-useless-tuples-from-type-checker](#remove-useless-tuples-from-type-checker)
+- ✅ [remove-trailing-spaces-from-type-checker](#remove-trailing-spaces-from-type-checker);
+- ✅ [remove-useless-spaces-from-type-checker](#remove-useless-spaces-from-type-checker);
+- ✅ [remove-useless-colon-from-type-checker](#remove-useless-colon-from-type-checker);
+- ✅ [remove-useless-tuples-from-type-checker](#remove-useless-tuples-from-type-checker);
+- ✅ [remove-useless-not-from-type-checker](#remove-useless-not-from-type-checker);
 
 ## Config
 
@@ -57,6 +58,7 @@ npm i @putout/plugin-printer -D
         "printer/remove-trailing-spaces-from-type-checker": "on",
         "printer/remove-useless-spaces-from-type-checker": "on",
         "printer/remove-useless-colon-from-type-checker": "on",
+        "printer/remove-useless-not-from-type-checker": "on",
         "printer/remove-useless-tuples-from-type-checker": "on"
     }
 }
@@ -294,6 +296,28 @@ export const beforeIf = createTypeChecker([
 ]);
 ```
 
+## remove-useless-not-from-type-checker
+
+Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/051b981021fd1e048b675106f0850211/2022b9797125016d4e5c5e6b5d4e066ab2e103ad).
+
+### ❌ Example of incorrect code
+
+```js
+export const beforeIf = createTypeChecker([
+    ['-: -> !+'],
+    ['+: -> !-'],
+]);
+```
+
+### ✅ Example of correct code
+
+```js
+export const beforeIf = createTypeChecker([
+    ['-: -> -'],
+    ['+: -> +'],
+]);
+```
+
 ## remove-useless-tuples-from-type-checker
 
 Checkout in 🐊[**Putout Editor**](https://putout.cloudcmd.io/#/gist/f53f386b607115e0a96f7e294e34761e/cefd72aba4fcade59bbf8faa59739bac5c2fe057).

packages/plugin-printer/lib/index.js

@@ -1,3 +1,4 @@
+import * as removeUselessNotFromTypeChecker from './remove-useless-not-from-type-checker/index.js';
 import * as removeUselessColonFromTypeChecker from './remove-useless-colon-from-type-checker/index.js';
 import * as addMissingColonToTypeChecker from './add-missing-colon-to-type-checker/index.js';
 import * as mergeTuplesOfTypeCheckers from './merge-tuples-of-type-checkers/index.js';
@@ -40,4 +41,5 @@ export const rules = {
     'merge-tuples-of-type-checkers': mergeTuplesOfTypeCheckers,
     'add-missing-colon-to-type-checker': addMissingColonToTypeChecker,
     'remove-useless-colon-from-type-checker': removeUselessColonFromTypeChecker,
+    'remove-useless-not-from-type-checker': removeUselessNotFromTypeChecker,
 };

packages/plugin-printer/lib/remove-useless-not-from-type-checker/fixture/remove-useless-not-from-type-checker-fix.js

@@ -0,0 +1,8 @@
+export const beforeIf = createTypeChecker([
+    ['-: -> -'],
+    ['+: -> +'],
+]);
+
+export const afterIf = is([
+    ['-: -> !', isInsideArray],
+]);

packages/plugin-printer/lib/remove-useless-not-from-type-checker/fixture/remove-useless-not-from-type-checker.js

@@ -0,0 +1,9 @@
+export const beforeIf = createTypeChecker([
+    ['-: -> !+'],
+    ['+: -> !-'],
+]);
+
+
+export const afterIf = is([
+    ['-: -> !', isInsideArray],
+]);

packages/plugin-printer/lib/remove-useless-not-from-type-checker/index.js

@@ -0,0 +1,79 @@
+import {operator, types} from 'putout';
+
+const {
+    isIdentifier,
+    isCallExpression,
+} = types;
+
+const {setLiteralValue} = operator;
+
+export const report = ({path, where}) => {
+    const {value} = path.node;
+    const withoutNot = removeNot(value, where);
+    
+    return `Avoid useless '!': '${value}' -> '${withoutNot}'`;
+};
+
+export const fix = ({path, where}) => {
+    const {value} = path.node;
+    setLiteralValue(path, removeNot(value, where));
+};
+export const traverse = ({push}) => ({
+    StringLiteral(path) {
+        const call = path.find(isCallExpression);
+        
+        if (!call)
+            return;
+        
+        if (!isIdentifier(call.node.callee, {name: 'createTypeChecker'}))
+            return;
+        
+        const {value} = path.node;
+        const where = createWhere(value);
+        
+        if (where.length)
+            push({
+                path,
+                where,
+            });
+    },
+});
+
+function createWhere(value) {
+    const where = [];
+    const includes = value.includes.bind(value);
+    const endsWith = value.endsWith.bind(value);
+    const push = where.push.bind(where);
+    
+    const tools = {
+        push,
+        includes,
+        endsWith,
+    };
+    
+    if (includes('!+'))
+        traceNot(tools);
+    
+    if (includes('!-'))
+        traceNot(tools);
+    
+    return where;
+}
+
+function traceNot({push, includes}) {
+    if (includes('!+'))
+        push('before-plus');
+    
+    if (includes('!-'))
+        push('before-minus');
+}
+
+function removeNot(value, where) {
+    if (where.includes('before-plus'))
+        value = value.replace('!+', '-');
+    
+    if (where.includes('before-minus'))
+        value = value.replace('!-', '+');
+    
+    return value;
+}

packages/plugin-printer/lib/remove-useless-not-from-type-checker/index.spec.js

@@ -0,0 +1,18 @@
+import {createTest} from '@putout/test';
+import * as plugin from './index.js';
+
+const test = createTest(import.meta.url, {
+    plugins: [
+        ['remove-useless-not-from-type-checker', plugin],
+    ],
+});
+
+test('printer: remove-useless-not-from-type-checker: report', (t) => {
+    t.report('remove-useless-not-from-type-checker', `Avoid useless '!': '-: -> !+' -> '-: -> -'`);
+    t.end();
+});
+
+test('printer: remove-useless-not-from-type-checker: transform', (t) => {
+    t.transform('remove-useless-not-from-type-checker');
+    t.end();
+});

packages/plugin-printer/test/fixture/remove-useless-not-from-type-checker-fix.js

@@ -0,0 +1,5 @@
+export const beforeIf = createTypeChecker(['-: -> -', '+: -> +']);
+
+export const afterIf = is([
+    ['-: -> !', isInsideArray],
+]);

packages/plugin-printer/test/fixture/remove-useless-not-from-type-checker.js

@@ -0,0 +1,9 @@
+export const beforeIf = createTypeChecker([
+    ['-: -> !+'],
+    ['+: -> !-'],
+]);
+
+
+export const afterIf = is([
+    ['-: -> !', isInsideArray],
+]);

packages/plugin-printer/test/printer.js

@@ -106,3 +106,8 @@ test('plugin-printer: transform: remove-useless-colon-from-type-checker', (t) =>
     t.transform('remove-useless-colon-from-type-checker');
     t.end();
 });
+
+test('plugin-printer: transform: remove-useless-not-from-type-checker', (t) => {
+    t.transform('remove-useless-not-from-type-checker');
+    t.end();
+});