fix: @putout/plugin-remove-useless-escape: report

Author: coderaiser

packages/plugin-react-hook-form/lib/v6-convert-as-to-render/index.js

@@ -29,16 +29,18 @@ export const match = () => ({
     },
 });
 
-export const replace = () => ({
-    [`
+const element = `
     <Controller
-      as={__a}
-      valueName="__b"
-      onChangeName="__c"
-      control={__d}
-      name="__e"
+        as={__a}
+        valueName="__b"
+        onChangeName="__c"
+        control={__d}
+        name="__e"
     />
-    `]: ({__a, __b, __c}) => `
+`;
+
+export const replace = () => ({
+    [element]: ({__a, __b, __c}) => `
         <Controller
             render={({field}) => {
                 const {value, onChange} = field;

packages/plugin-remove-useless-escape/lib/remove-useless-escape.js

@@ -1,6 +1,6 @@
 import emojiRegex from 'emoji-regex';
 
-export const report = () => 'Unnecessary escape character';
+export const report = () => 'Avoid useless escape';
 
 export const fix = (path) => {
     if (path.isStringLiteral()) {
@@ -32,7 +32,7 @@ export const traverse = ({push}) => ({
             if (raw.includes('${'))
                 return;
 
-            if (raw.includes('{('))
+            if (raw.includes('$('))
                 return push(path);
 
             if (isEscaped(raw))

packages/plugin-remove-useless-escape/test/fixture/multiline.js

@@ -0,0 +1,15 @@
+export const replace = () => ({
+    [element]: ({__a, __b, __c}) => `
+        <Controller
+            render={({field}) => {
+                const {value, onChange} = field;
+                return (
+                    <${__a.name} ${__c.value}={onChange} onBlur={onBlur} ${__b.value}={value} />
+                )
+            }}
+          control={__d}
+          name="__e"
+        />
+    `,
+});
+

packages/plugin-remove-useless-escape/test/remove-useless-escape.js

@@ -11,12 +11,12 @@ const test = createTest(import.meta.url, {
 });
 
 test('plugin-remove-useless-escape: report: string', (t) => {
-    t.report('string', 'Unnecessary escape character');
+    t.report('string', 'Avoid useless escape');
     t.end();
 });
 
 test('plugin-remove-useless-escape: report: a: ^', (t) => {
-    t.report('a', 'Unnecessary escape character');
+    t.report('a', 'Avoid useless escape');
     t.end();
 });
 
@@ -115,6 +115,11 @@ test('plugin-remove-useless-escape: transform: z', (t) => {
     t.end();
 });
 
+test('plugin-remove-useless-escape: no report: multiline', (t) => {
+    t.noReport('multiline');
+    t.end();
+});
+
 test('plugin-remove-useless-escape: transform: single-quote-inside-template', (t) => {
     t.transform('single-quote-inside-template');
     t.end();