REMOVE: redundant assignments, comments

Author: Spazcool

app.js

@@ -61,7 +61,6 @@ app.get('/recent', (req, res) => {
 
 app.get('/:uuid', (req, res) => {
   loadDatabase((allItems) => {
-    addMarkdown(allItems);
     const matches = searchDatabase(req.params, allItems);
     if (matches.length === 0) {
       logScanned(req.params.uuid);
@@ -71,9 +70,9 @@ app.get('/:uuid', (req, res) => {
       });
       return;
     }
+    addMarkdown(matches[0]);
     addSimilarItems(matches[0], allItems);
     logScanned(req.params.uuid, matches[0].fixture);
-    // modifyContent(matches[0], allItems
     res.render('item', matches[0]);
   });
 });

googleSpreadsheet.js

@@ -34,23 +34,18 @@ function searchDatabase(query, rows) {
   return matches;
 }
 
-function addSimilarItems(object, objects) {
-  const obj = object;
-  const allObj = objects;
+function addSimilarItems(obj, allObj) {
   obj.similarItems = searchDatabase({ fixture: obj.fixture }, allObj)
     .filter(item => item.uuid !== obj.uuid)
     .splice(0, 3);
   return obj;
 }
 
-function addMarkdown(objects) {
-  const objs = objects;
-  for (let i = 0; i < objs.length; i += 1) {
-    objs[i].HOWTO = marked(objs[i].HOWTO);
-    objs[i].details = marked(objs[i].details);
-    objs[i].Troubleshooting = marked(objs[i].Troubleshooting);
-  }
-  return objs;
+function addMarkdown(obj) {
+  obj.HOWTO = marked(obj.HOWTO);
+  obj.details = marked(obj.details);
+  obj.Troubleshooting = marked(obj.Troubleshooting);
+  return obj;
 }
 
 module.exports = {

views/notFound.ejs

@@ -2,7 +2,7 @@
 
 <img class="col-xs-12 col-lg-4 col-lg-offset-4" src="/emoji.png" alt="" />
 <article style='margin-top:2em'class="col-xs-12 col-lg-4 col-lg-offset-4">
-  <p>Sorry, item not found with the id: </p>
+  <p>Sorry, item not found with the id:</p>
   <p>
     <strong><%- id %></strong>
   </p>