Conversation
Contributor
rakuda-san-desu
left a comment
rakuda-san-desu
left a comment
There was a problem hiding this comment.
対応ありがとうございます！
コミットの整理をしていただけたら、それ以外は良さそうです🙆♀️
yasulab
reviewed
Jul 30, 2025
Member
There was a problem hiding this comment.
url: https://codeclub.org/ja/clubs/1700a138-2909-4e4e-9e75-88ebcbbbc55a
@nacchan99 @rakuda-san-desu こちらリンク先にある活動内容を自分の方で確認してから対応した方が良さそうでしたので、マージするかどうかは自分の方で一旦引き取りますね! PR のご対応ありがとうございました...!! 🙏✨
rakuda-san-desu
force-pushed
the
add-coderdojo-harima
branch
from
8e33cb0 to
e9045f1
Compare
rakuda-san-desu
approved these changes
Jul 30, 2025
Contributor
|
@yasulab 不要なコミットをカットしました & approved しました！ |
並行して複数のPRがDojoを追加する際に、同じIDを使用してしまう 問題を事前に検出するためのテストを追加。 これにより、マージ前にCI/CDで重複IDを自動検出できるようになる。
PR #1738で砧（ID: 342）が先にマージされたため、 播磨科学公園都市のIDを342から343に変更。 並行作業による重複ID問題を解決。
Member
|
諸々の対応が完了したので（細かなテスト追加、重複 ID の対処なども対応したので）、こちらマージしますね！ご対応ありがとうございました...!! (≧∇≦)b✨ |
yasulab
added a commit
that referenced
this pull request
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと