📝 created_at を自動設定項目として明記し、入力ミスを防ぐ#1771
Merged
Merged
Conversation
Contributor
|
対応ありがとうござます🙏✨ |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1770
概要
新規Dojoの追加時における
created_atフィールドの入力ミスを防ぐため、ドキュメントを更新しました。背景
created_atの年を誤って入力(2015年と2025年を間違える)した問題が発生created_atの入力ミスに対応したい #1770解決方法
rails dojos:update_db_by_yamlタスクは新規レコードに対して自動的に現在時刻をcreated_atに設定する仕組みになっています:この仕組みを活かし、新規Dojoの追加時には
created_atを手動入力させないことで、入力ミスを構造的に防ぎます。変更内容
created_atの記載を削除created_atを「入力しない」項目として明記(idと同様)rails dojos:migrate_adding_id_to_yamlの説明を更新(idだけでなくcreated_atも追加されることを明記)テスト
関連
created_atの入力ミスに対応したい #1770