From a89a9fe12ef9b7a22c90e99355c0845a6eef76af Mon Sep 17 00:00:00 2001 From: fmuntean Date: Fri, 15 May 2026 10:00:32 +0200 Subject: [PATCH 1/3] add EnableAccountVerifier flag --- api/v1alpha1/docs/apiref.adoc | 4 ++++ api/v1alpha1/toolchainconfig_types.go | 6 ++++++ api/v1alpha1/zz_generated.deepcopy.go | 5 +++++ api/v1alpha1/zz_generated.openapi.go | 7 +++++++ 4 files changed, 22 insertions(+) diff --git a/api/v1alpha1/docs/apiref.adoc b/api/v1alpha1/docs/apiref.adoc index 4ce4408d..d0ed20fc 100644 --- a/api/v1alpha1/docs/apiref.adoc +++ b/api/v1alpha1/docs/apiref.adoc @@ -2139,6 +2139,10 @@ considered enabled. Only listed integrations are hidden. + | | Optional: \{} + | *`accountVerifierURL`* __string__ | AccountVerifierURL is the URL used to call the account verifier service + | | Optional: \{} + +| *`enableAccountVerifier`* __boolean__ | EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, + +which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's + +response. When set to false or not set, the account-verifier is still called but the response is only logged. + | | Optional: \{} + + |=== diff --git a/api/v1alpha1/toolchainconfig_types.go b/api/v1alpha1/toolchainconfig_types.go index afc1ebf6..5c697747 100644 --- a/api/v1alpha1/toolchainconfig_types.go +++ b/api/v1alpha1/toolchainconfig_types.go @@ -261,6 +261,12 @@ type RegistrationServiceConfig struct { // AccountVerifierURL is the URL used to call the account verifier service // +optional AccountVerifierURL *string `json:"accountVerifierURL,omitempty"` + + // EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, + // which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's + // response. When set to false or not set, the account-verifier is still called but the response is only logged. + // +optional + EnableAccountVerifier *bool `json:"enableAccountVerifier,omitempty"` } // RegistrationServiceAnalyticsConfig contains the subset of registration service configuration parameters related to analytics diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go index 02470143..c5f35c79 100644 --- a/api/v1alpha1/zz_generated.deepcopy.go +++ b/api/v1alpha1/zz_generated.deepcopy.go @@ -1937,6 +1937,11 @@ func (in *RegistrationServiceConfig) DeepCopyInto(out *RegistrationServiceConfig *out = new(string) **out = **in } + if in.EnableAccountVerifier != nil { + in, out := &in.EnableAccountVerifier, &out.EnableAccountVerifier + *out = new(bool) + **out = **in + } } // DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new RegistrationServiceConfig. diff --git a/api/v1alpha1/zz_generated.openapi.go b/api/v1alpha1/zz_generated.openapi.go index 17a90d31..38543e38 100644 --- a/api/v1alpha1/zz_generated.openapi.go +++ b/api/v1alpha1/zz_generated.openapi.go @@ -2658,6 +2658,13 @@ func schema_codeready_toolchain_api_api_v1alpha1_RegistrationServiceConfig(ref c Format: "", }, }, + "enableAccountVerifier": { + SchemaProps: spec.SchemaProps{ + Description: "EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's response. When set to false or not set, the account-verifier is still called but the response is only logged.", + Type: []string{"boolean"}, + Format: "", + }, + }, }, }, }, From 76e7bbd5884ab06493410279c89d04d035aa1786 Mon Sep 17 00:00:00 2001 From: fmuntean Date: Mon, 18 May 2026 10:16:21 +0200 Subject: [PATCH 2/3] rename flag --- api/v1alpha1/docs/apiref.adoc | 2 +- api/v1alpha1/toolchainconfig_types.go | 2 +- api/v1alpha1/zz_generated.deepcopy.go | 4 ++-- api/v1alpha1/zz_generated.openapi.go | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/api/v1alpha1/docs/apiref.adoc b/api/v1alpha1/docs/apiref.adoc index d0ed20fc..5121419e 100644 --- a/api/v1alpha1/docs/apiref.adoc +++ b/api/v1alpha1/docs/apiref.adoc @@ -2139,7 +2139,7 @@ considered enabled. Only listed integrations are hidden. + | | Optional: \{} + | *`accountVerifierURL`* __string__ | AccountVerifierURL is the URL used to call the account verifier service + | | Optional: \{} + -| *`enableAccountVerifier`* __boolean__ | EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, + +| *`accountVerifierEnabled`* __boolean__ | EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, + which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's + response. When set to false or not set, the account-verifier is still called but the response is only logged. + | | Optional: \{} + diff --git a/api/v1alpha1/toolchainconfig_types.go b/api/v1alpha1/toolchainconfig_types.go index 5c697747..97251553 100644 --- a/api/v1alpha1/toolchainconfig_types.go +++ b/api/v1alpha1/toolchainconfig_types.go @@ -266,7 +266,7 @@ type RegistrationServiceConfig struct { // which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's // response. When set to false or not set, the account-verifier is still called but the response is only logged. // +optional - EnableAccountVerifier *bool `json:"enableAccountVerifier,omitempty"` + AccountVerifierEnabled *bool `json:"accountVerifierEnabled,omitempty"` } // RegistrationServiceAnalyticsConfig contains the subset of registration service configuration parameters related to analytics diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go index c5f35c79..b7e2d92d 100644 --- a/api/v1alpha1/zz_generated.deepcopy.go +++ b/api/v1alpha1/zz_generated.deepcopy.go @@ -1937,8 +1937,8 @@ func (in *RegistrationServiceConfig) DeepCopyInto(out *RegistrationServiceConfig *out = new(string) **out = **in } - if in.EnableAccountVerifier != nil { - in, out := &in.EnableAccountVerifier, &out.EnableAccountVerifier + if in.AccountVerifierEnabled != nil { + in, out := &in.AccountVerifierEnabled, &out.AccountVerifierEnabled *out = new(bool) **out = **in } diff --git a/api/v1alpha1/zz_generated.openapi.go b/api/v1alpha1/zz_generated.openapi.go index 38543e38..778782c8 100644 --- a/api/v1alpha1/zz_generated.openapi.go +++ b/api/v1alpha1/zz_generated.openapi.go @@ -2658,7 +2658,7 @@ func schema_codeready_toolchain_api_api_v1alpha1_RegistrationServiceConfig(ref c Format: "", }, }, - "enableAccountVerifier": { + "accountVerifierEnabled": { SchemaProps: spec.SchemaProps{ Description: "EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's response. When set to false or not set, the account-verifier is still called but the response is only logged.", Type: []string{"boolean"}, From 649b1dfb564f735127cc1526ec304a6a6e6a2f1f Mon Sep 17 00:00:00 2001 From: fmuntean Date: Mon, 18 May 2026 10:16:59 +0200 Subject: [PATCH 3/3] update doc --- api/v1alpha1/docs/apiref.adoc | 4 +--- api/v1alpha1/toolchainconfig_types.go | 4 +--- api/v1alpha1/zz_generated.openapi.go | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/api/v1alpha1/docs/apiref.adoc b/api/v1alpha1/docs/apiref.adoc index 5121419e..40e3379e 100644 --- a/api/v1alpha1/docs/apiref.adoc +++ b/api/v1alpha1/docs/apiref.adoc @@ -2139,9 +2139,7 @@ considered enabled. Only listed integrations are hidden. + | | Optional: \{} + | *`accountVerifierURL`* __string__ | AccountVerifierURL is the URL used to call the account verifier service + | | Optional: \{} + -| *`accountVerifierEnabled`* __boolean__ | EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, + -which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's + -response. When set to false or not set, the account-verifier is still called but the response is only logged. + | | Optional: \{} + +| *`accountVerifierEnabled`* __boolean__ | AccountVerifierEnabled controls whether the registration service acts on responses from the account-verifier service. + | | Optional: \{} + |=== diff --git a/api/v1alpha1/toolchainconfig_types.go b/api/v1alpha1/toolchainconfig_types.go index 97251553..8090f675 100644 --- a/api/v1alpha1/toolchainconfig_types.go +++ b/api/v1alpha1/toolchainconfig_types.go @@ -262,9 +262,7 @@ type RegistrationServiceConfig struct { // +optional AccountVerifierURL *string `json:"accountVerifierURL,omitempty"` - // EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, - // which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's - // response. When set to false or not set, the account-verifier is still called but the response is only logged. + // AccountVerifierEnabled controls whether the registration service acts on responses from the account-verifier service. // +optional AccountVerifierEnabled *bool `json:"accountVerifierEnabled,omitempty"` } diff --git a/api/v1alpha1/zz_generated.openapi.go b/api/v1alpha1/zz_generated.openapi.go index 778782c8..467e765a 100644 --- a/api/v1alpha1/zz_generated.openapi.go +++ b/api/v1alpha1/zz_generated.openapi.go @@ -2660,7 +2660,7 @@ func schema_codeready_toolchain_api_api_v1alpha1_RegistrationServiceConfig(ref c }, "accountVerifierEnabled": { SchemaProps: spec.SchemaProps{ - Description: "EnableAccountVerifier controls whether the registration service acts on responses from the account-verifier service, which verifies disposable email domains. When set to true, the registration service will enforce the account-verifier's response. When set to false or not set, the account-verifier is still called but the response is only logged.", + Description: "AccountVerifierEnabled controls whether the registration service acts on responses from the account-verifier service.", Type: []string{"boolean"}, Format: "", },