Skip to content

refactor: bind to 127.0.0.1:8080 by default#43

Merged
xcoulon merged 2 commits into
codeready-toolchain:masterfrom
xcoulon:bind_address
Jan 26, 2026
Merged

refactor: bind to 127.0.0.1:8080 by default#43
xcoulon merged 2 commits into
codeready-toolchain:masterfrom
xcoulon:bind_address

Conversation

@xcoulon
Copy link
Copy Markdown
Collaborator

@xcoulon xcoulon commented Jan 15, 2026

when deployed, the container will be accessed via kube-rbac-proxies

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Summary by CodeRabbit

  • New Features

    • Startup logs now show the server listen address for clearer runtime visibility
  • Bug Fixes

    • Server default changed to listen on localhost only (127.0.0.1), reducing exposure
  • Documentation

    • Clarifying inline comments added for the server listen configuration

✏️ Tip: You can customize this high-level summary in your review settings.

when deployed, the container will be accessed via kube-rbac-proxies

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 15, 2026

Walkthrough

Changed the MCP server default bind address in the Containerfile from 0.0.0.0 to 127.0.0.1, added inline comments to compose.yaml environment lines, and extended startup logging in cmd/start_server.go to include a "listen" field.

Changes

Cohort / File(s) Summary
Container image config
Containerfile
Updated ENV ARGOCD_MCP_SERVER_LISTEN_HOST from 0.0.0.0 to 127.0.0.1 (restricts listen address to localhost)
Compose/environment docs
compose.yaml
Added inline comments next to ARGOCD_MCP_SERVER_LISTEN_HOST=0.0.0.0 occurrences (no value changes)
Startup logging
cmd/start_server.go
Extended startup log output to include the listen field alongside transport, argocd-url, insecure, and debug

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • mfrancisc
  • rsoaresd

Poem

🐰 I hop in quietly to say hello,
The server listens only where I go—localhost so neat,
Logs now whisper where the bind will be,
Comments tucked in compose for clarity sweet,
A tiny change, a safer seat. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the default binding address to 127.0.0.1 in the Containerfile and adding documentation in compose.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@rsoaresd rsoaresd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@xcoulon
Copy link
Copy Markdown
Collaborator Author

xcoulon commented Jan 16, 2026

I need to check if this is not going to cause troubles with the health endpoints which may become unreachable, hence resulting in pod being constantly restarted :/

@xcoulon xcoulon marked this pull request as draft January 16, 2026 12:37
@xcoulon xcoulon marked this pull request as ready for review January 26, 2026 08:14
@xcoulon xcoulon merged commit b78b968 into codeready-toolchain:master Jan 26, 2026
6 checks passed
@xcoulon xcoulon deleted the bind_address branch January 26, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants