Skip to content

SANDBOX-1769 | feature: definition of the "disabled integrations" in the CRD#1256

Open
MikelAlejoBR wants to merge 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enabled-integrations-ho
Open

SANDBOX-1769 | feature: definition of the "disabled integrations" in the CRD#1256
MikelAlejoBR wants to merge 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enabled-integrations-ho

Conversation

@MikelAlejoBR
Copy link
Copy Markdown

@MikelAlejoBR MikelAlejoBR commented Apr 10, 2026

Defines the "disabled integrations" field for the ToolchainConfig CRD.

Related PRs

Jira ticket

[SANDBOX-1769]

Summary by CodeRabbit

  • New Features
    • Added an optional host setting to configure disabled integrations. If omitted or empty, all integrations remain enabled by default; if specific integrations are listed, only those will be hidden/disabled in the UI.
    • No other user-visible changes in this release.

@openshift-ci openshift-ci bot requested review from rsoaresd and xcoulon April 10, 2026 20:32
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Walkthrough

Added an optional spec.host.disabledIntegrations field to the ToolchainConfig CRD schema (array of strings). Also updated the github.com/codeready-toolchain/api module version in go.mod.

Changes

Cohort / File(s) Summary
CRD Schema Update
config/crd/bases/toolchain.dev.openshift.com_toolchainconfigs.yaml
Added optional spec.host.disabledIntegrations (type: array of string, x-kubernetes-list-type: set) with description indicating nil/empty means all integrations enabled; listed values hide/disable those integrations in the UI.
Dependency Bump
go.mod
Updated github.com/codeready-toolchain/api module requirement to a newer commit/version. No other dependency changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: adding the 'disabled integrations' field definition to the ToolchainConfig CRD, which aligns with the actual modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-ho branch from ace0371 to 45002fd Compare April 14, 2026 15:43
@MikelAlejoBR MikelAlejoBR changed the title SANDBOX-1769 | feature: definition of the "enabled integrations" in the CRD SANDBOX-1769 | feature: definition of the "disabled integrations" in the CRD Apr 14, 2026
@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-ho branch from 71f1ab1 to e7459bc Compare April 15, 2026 16:28
@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-ho branch 2 times, most recently from 73226e3 to 80c06ba Compare April 15, 2026 22:00
Defines the "disabled integrations" field for the ToolchainConfig CRD.

SANDBOX-1769
@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-ho branch from 80c06ba to 6db26ed Compare April 16, 2026 14:10
@sonarqubecloud
Copy link
Copy Markdown

@MikelAlejoBR
Copy link
Copy Markdown
Author

/retest

Copy link
Copy Markdown
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc, MikelAlejoBR

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants