-
Notifications
You must be signed in to change notification settings - Fork 44
config: enable CodeRabbit Multi-Repo Analysis #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
rsoaresd
wants to merge
2
commits into
codeready-toolchain:master
from
rsoaresd:coderrabit_multi_repo_m
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| inheritance: true | ||
| knowledge_base: | ||
| linked_repositories: | ||
| - repository: 'codeready-toolchain/toolchain-common' | ||
| instructions: > | ||
| toolchain-common contains shared controllers, utilities, and libraries used by member-operator. | ||
|
|
||
| When reviewing member-operator changes: | ||
| - Check if member-operator is using deprecated or outdated patterns from toolchain-common when newer/better utilities exist. | ||
| - Verify behavioral assumptions — if member-operator expects specific return values or side effects from toolchain-common functions, check if that behavior is actually implemented. | ||
| - If member-operator duplicates logic that already exists in toolchain-common (pkg/cluster, pkg/condition, pkg/configuration, pkg/status), suggest using the shared implementation instead. | ||
| - Flag if member-operator is making assumptions about toolchain-common's internal state or behavior that isn't documented or guaranteed. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pity that we cannot add more than one linked repos. In this case I'm wondering if it's better to link toolchain-common or it's more critical to link host-operator. In theory they should not depend on each other but in practice there is some dependency between the two operators.