Skip to content

Remove unused DurationBeforeChangeTierRequestDeletion config #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajivnathan merged 3 commits into from
Feb 26, 2026
Merged

Remove unused DurationBeforeChangeTierRequestDeletion config #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d27e830
Remove unused DurationBeforeChangeTierRequestDeletion config
rajivnathan Feb 25, 2026
c577f26
Merge branch 'master' of github.com:codeready-toolchain/registration-…
rajivnathan Feb 26, 2026
e43a7ab
Update deps
rajivnathan Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ toolchain go1.24.13

require (
github.com/aws/aws-sdk-go v1.44.100
github.com/codeready-toolchain/api v0.0.0-20260108115150-4c6695ed18de
github.com/codeready-toolchain/toolchain-common v0.0.0-20260225205316-85e4bef507f2
github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7
github.com/codeready-toolchain/toolchain-common v0.0.0-20260226040150-d7d5d0163ff7
Comment on lines +9 to +10
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Verifying upstream commits exist ==="

# Check codeready-toolchain/api commit 912fcbd23dc7
echo "Checking github.com/codeready-toolchain/api commit 912fcbd23dc7..."
if curl -fsS "https://api.github.com/repos/codeready-toolchain/api/commits/912fcbd23dc7" >/dev/null 2>&1; then
  echo "✓ api commit 912fcbd23dc7 exists"
  # Get commit message to verify it's related to the expected change
  curl -fsS "https://api.github.com/repos/codeready-toolchain/api/commits/912fcbd23dc7" | \
    jq -r '.commit.message' | head -5
else
  echo "✗ api commit 912fcbd23dc7 not found"
fi

echo ""

# Check codeready-toolchain/toolchain-common commit d7d5d0163ff7
echo "Checking github.com/codeready-toolchain/toolchain-common commit d7d5d0163ff7..."
if curl -fsS "https://api.github.com/repos/codeready-toolchain/toolchain-common/commits/d7d5d0163ff7" >/dev/null 2>&1; then
  echo "✓ toolchain-common commit d7d5d0163ff7 exists"
  # Get commit message to verify it's related to the expected change
  curl -fsS "https://api.github.com/repos/codeready-toolchain/toolchain-common/commits/d7d5d0163ff7" | \
    jq -r '.commit.message' | head -5
else
  echo "✗ toolchain-common commit d7d5d0163ff7 not found"
fi

Repository: codeready-toolchain/registration-service

Length of output: 504

The api dependency commit does not exist in the upstream repository.

The commit hash for github.com/codeready-toolchain/api (912fcbd23dc7) cannot be found in the upstream repo. The toolchain-common commit (d7d5d0163ff7) exists and correctly removes the DurationBeforeChangeTierRequestDeletion config, but it references an invalid api dependency update.

Verify the correct api commit hash that corresponds to PR #499 (removing the unused config) and update line 9 accordingly.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@go.mod` around lines 9 - 10, The go.mod entry for module
github.com/codeready-toolchain/api references a non-existent commit hash
(912fcbd23dc7); locate the correct commit hash in the upstream
codeready-toolchain/api repo that corresponds to PR `#499` (the change removing
DurationBeforeChangeTierRequestDeletion) and replace the current hash on the
github.com/codeready-toolchain/api line in go.mod with that valid commit version
so the dependency resolves correctly (leave the toolchain-common line
unchanged).

github.com/go-logr/logr v1.4.2
github.com/gofrs/uuid v4.2.0+incompatible
github.com/pkg/errors v0.9.1
Expand Down
10 changes: 4 additions & 6 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,10 @@ github.com/cloudflare/circl v1.1.0/go.mod h1:prBCrKB9DV4poKZY1l9zBXg2QJY7mvgRvtM
github.com/cloudflare/circl v1.6.3 h1:9GPOhQGF9MCYUeXyMYlqTR6a5gTrgR/fBLXvUgtVcg8=
github.com/cloudflare/circl v1.6.3/go.mod h1:2eXP6Qfat4O/Yhh8BznvKnJ+uzEoTQ6jVKJRn81BiS4=
github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
github.com/codeready-toolchain/api v0.0.0-20260108115150-4c6695ed18de h1:rc39ZRUk2AyADzH+bt5On7V7qJz6syUrI4qNyCSXY3o=
github.com/codeready-toolchain/api v0.0.0-20260108115150-4c6695ed18de/go.mod h1:O/HyAcz6fynt3LXr8wTGaIXt+0v6BpkiJvDxNQDCqyA=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260108130331-10ca562525fe h1:TOSa/kVCYoLXKX7B/uBLnJsi4Pnaf6nD9K0flumVr6o=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260108130331-10ca562525fe/go.mod h1:rjveL3/1VJeHnDwhvWCEF5jCFRC4xAz93DQp1rKPn3Y=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260225205316-85e4bef507f2 h1:Cn60rNw0cK4GrtJdTbaDfBr9Nbl0gIGRwrV4raSzM6o=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260225205316-85e4bef507f2/go.mod h1:ZiaHcxOYExpyzOwIQjpggJm9LvcdNsxCMF+qrXOVkr0=
github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7 h1:1YCopXDF7WSjhM7sQAFoNeJvoIVPCHDY35jNVqc0Xh4=
github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7/go.mod h1:PMg6kNHuCGNlu3MOdrCisqGkBpvzB0qS1+E6nrXxPAc=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260226040150-d7d5d0163ff7 h1:NLTKW/An6PfcgqUyjeloAl0cmR0/lJopURsMMY/VZcs=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260226040150-d7d5d0163ff7/go.mod h1:TtwbNKTtHxDEaO2fOhJbYM4S1FykJHOf/4/nCw7hFwo=
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
Expand Down
Loading