refactor: drop MetricsConfig from ToolchainStatus type (#520)

remove the `Metrics` option from the helpers to generate `ToolchainConfig` in tests

---------

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>

Author: xcoulon

codecov.yaml

@@ -10,12 +10,12 @@ coverage:
   # solid green color.
   range: "20...60"
 
-# See https://docs.codecov.com/docs/commit-status
+  # See https://docs.codecov.com/docs/commit-status
   status:
     # project will give us the diff in the total code coverage between a commit
     # and its parent
     project:
-       default:
+      default:
          # Allow the coverage to drop by 1% and posting a success status.
          threshold: 1%
     # Patch gives just the coverage of the patch

go.mod

@@ -26,7 +26,7 @@ require (
 )
 
 require (
-	github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7
+	github.com/codeready-toolchain/api v0.0.0-20260305144020-4ff0e6b6e174
 	github.com/ghodss/yaml v1.0.0
 	github.com/google/go-cmp v0.7.0
 	github.com/google/go-github/v52 v52.0.0

go.sum

@@ -20,8 +20,8 @@ github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XL
 github.com/cloudflare/circl v1.1.0/go.mod h1:prBCrKB9DV4poKZY1l9zBXg2QJY7mvgRvtMxxK7fi4I=
 github.com/cloudflare/circl v1.6.3 h1:9GPOhQGF9MCYUeXyMYlqTR6a5gTrgR/fBLXvUgtVcg8=
 github.com/cloudflare/circl v1.6.3/go.mod h1:2eXP6Qfat4O/Yhh8BznvKnJ+uzEoTQ6jVKJRn81BiS4=
-github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7 h1:1YCopXDF7WSjhM7sQAFoNeJvoIVPCHDY35jNVqc0Xh4=
-github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7/go.mod h1:PMg6kNHuCGNlu3MOdrCisqGkBpvzB0qS1+E6nrXxPAc=
+github.com/codeready-toolchain/api v0.0.0-20260305144020-4ff0e6b6e174 h1:hed3ZyardxswS6yMB0ME9l3vEkO+pFouyk4dvIiAQOo=
+github.com/codeready-toolchain/api v0.0.0-20260305144020-4ff0e6b6e174/go.mod h1:PMg6kNHuCGNlu3MOdrCisqGkBpvzB0qS1+E6nrXxPAc=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

pkg/test/config/toolchainconfig.go

@@ -145,24 +145,6 @@ func (o DeactivationOption) UserSignupUnverifiedRetentionDays(value int) Deactiv
 	return o
 }
 
-type MetricsOption struct {
-	*ToolchainConfigOptionImpl
-}
-
-func Metrics() *MetricsOption {
-	o := &MetricsOption{
-		ToolchainConfigOptionImpl: &ToolchainConfigOptionImpl{},
-	}
-	return o
-}
-
-func (o MetricsOption) ForceSynchronization(value bool) MetricsOption {
-	o.addFunction(func(config *toolchainv1alpha1.ToolchainConfig) {
-		config.Spec.Host.Metrics.ForceSynchronization = &value
-	})
-	return o
-}
-
 type NotificationsOption struct {
 	*ToolchainConfigOptionImpl
 }