-
Notifications
You must be signed in to change notification settings - Fork 25
[SANDBOX-1701] chore: upgrade to OCP 4.21 dependencies #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bbfe574
chore: upgrade to OCP 4.21 dependencies
metlos f8505ba
update to api that has the deps in sync with what is needed here
metlos fbd4bba
go.sum
metlos 9f768c4
Revert the upgrade to controller-runtime 0.22
metlos 458d0e3
merge master
metlos 7a27a3b
merge master
metlos 04ab229
clean up the upgraded versions of stuff to exactly just what's needed…
metlos 7416591
upgrade to the lastest toolchain/api and update kubectl to be in line…
metlos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: codeready-toolchain/toolchain-common
Length of output: 1821
🌐 Web query:
What Kubernetes minor version compatibility is documented for sigs.k8s.io/controller-runtime v0.21.0 and v0.22.0?💡 Result:
Sources:
[1] controller-runtime repo README “Compatibility” table (CR v0.21 → client-go v0.33; CR v0.22 → client-go v0.34) (github.com)
[2] client-go INSTALL.md:
v0.x.ytags correspond to Kubernetesv1.x.y(chromium.googlesource.com)Citations:
Upgrade
sigs.k8s.io/controller-runtimetov0.22.0to match Kubernetesv0.34.1modules.Line 25 keeps
sigs.k8s.io/controller-runtime v0.21.0while Lines 22-24 use Kubernetes modules atv0.34.1. According to controller-runtime's official compatibility matrix, v0.21.0 is designed for k8s v0.33.x, while v0.22.0 pairs with v0.34.x. This version skew causes API/type incompatibilities in controller code and violates maintainability requirements.🤖 Prompt for AI Agents