You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
toolchain-common contains shared controllers, utilities, and libraries used by toolchain-e2e.
7
+
8
+
When reviewing toolchain-e2e changes:
9
+
- Check if toolchain-e2e is using deprecated or outdated patterns from toolchain-common when newer/better utilities exist.
10
+
- Verify behavioral assumptions — if toolchain-e2e expects specific return values or side effects from toolchain-common functions, check if that behavior is actually implemented.
11
+
- If toolchain-e2e duplicates logic that already exists in toolchain-common (pkg/cluster, pkg/condition, pkg/configuration, pkg/status), suggest using the shared implementation instead.
12
+
- Flag if toolchain-e2e is making assumptions about toolchain-common's internal state or behavior that isn't documented or guaranteed.
0 commit comments