Skip to content

Commit 9132258

Browse files
authored
improvements (#1248)
1 parent eb77a8e commit 9132258

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

build/devsandbox-dashboard/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,6 @@ WORKDIR /app
5151
# Increase shared memory for browsers (recommended for Playwright)
5252
RUN mkdir -p /dev/shm && chmod 1777 /dev/shm
5353

54-
COPY . .
55-
5654
# Install Firefox required dependencies
5755
RUN yum install -y \
5856
libxcb \
@@ -76,4 +74,6 @@ RUN yum install -y \
7674
libX11-xcb && \
7775
yum clean all
7876

77+
COPY . .
78+
7979
CMD ["/bin/bash"]

go.mod

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,3 +145,5 @@ require (
145145
go 1.24.4
146146

147147
toolchain go1.24.11
148+
149+
tool github.com/playwright-community/playwright-go/cmd/playwright

make/devsandbox-dashboard.mk

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,8 @@ endif
3232
e2e-run-devsandbox-dashboard: HOST_NS=$(shell oc get projects -l app=host-operator --output=name -o jsonpath='{range .items[*]}{.metadata.name}{"\n"}{end}' | sort | tail -n 1)
3333
e2e-run-devsandbox-dashboard: RHDH=https://rhdh-${DEVSANDBOX_DASHBOARD_NS}.$(shell oc get ingress.config.openshift.io/cluster -o jsonpath='{.spec.domain}')
3434
e2e-run-devsandbox-dashboard:
35-
$(eval PWGO_VER := $(shell grep -oE "playwright-go v\S+" go.mod | sed 's/playwright-go //g'))
36-
@echo "Installing Playwright CLI version: $(PWGO_VER)"
37-
go install github.com/playwright-community/playwright-go/cmd/playwright@$(PWGO_VER)
3835
@echo "Installing Firefox browser for Playwright..."
39-
$(GOPATH)/bin/playwright install firefox
36+
go tool playwright install firefox
4037

4138
@echo "Running Developer Sandbox Dashboard setup e2e tests..."
4239
DEVSANDBOX_DASHBOARD_NS=${DEVSANDBOX_DASHBOARD_NS} go test "./test/e2e/devsandbox-dashboard/setup" -v -timeout=10m -failfast

0 commit comments

Comments
 (0)