SANDBOX-1392: member-pair Drop dependency on Che instance (#1197)

* SANDBOX-1392: Drop dependency on Che instance , change the toolchain-status test  to use console instead where che was required and used to determine the member status. 

Signed-off-by: Feny Mehta <fbm3307@gmail.com>

Author: fbm3307

test/e2e/toolchainstatus_test.go

@@ -20,22 +20,22 @@ func TestToolchainStatusUnready(t *testing.T) {
 	VerifyToolchainStatus(t, hostAwait, memberAwait)
 
 	t.Run("verify updated toolchainconfig is synced - go to unready", func(t *testing.T) {
-		// set the che required flag to true to force an error on the memberstatus (che is not installed in e2e test environments)
-		memberConfigurationWithCheRequired := testconfig.ModifyMemberOperatorConfigObj(memberAwait.GetMemberOperatorConfig(t), testconfig.Che().Required(true))
-		hostAwait.UpdateToolchainConfig(t, testconfig.Members().Default(memberConfigurationWithCheRequired.Spec))
+		// set an invalid console route name to force an error on the memberstatus (console route won't be found)
+		memberConfigurationWithInvalidConsole := testconfig.ModifyMemberOperatorConfigObj(memberAwait.GetMemberOperatorConfig(t), testconfig.Console().RouteName("nonexistent-console-route"))
+		hostAwait.UpdateToolchainConfig(t, testconfig.Members().Default(memberConfigurationWithInvalidConsole.Spec))
 
 		err := memberAwait.WaitForMemberStatus(t,
 			wait.UntilMemberStatusHasConditions(wait.ToolchainStatusComponentsNotReady("[routes]")))
-		require.NoError(t, err, "failed while waiting for MemberStatus to contain error due to che being required")
+		require.NoError(t, err, "failed while waiting for MemberStatus to contain error due to invalid console route")
 
 		_, err = hostAwait.WaitForToolchainStatus(t,
 			wait.UntilToolchainStatusHasConditions(wait.ToolchainStatusComponentsNotReady("[members]"), wait.ToolchainStatusUnreadyNotificationNotCreated()))
-		require.NoError(t, err, "failed while waiting for ToolchainStatus to contain error due to che being required")
+		require.NoError(t, err, "failed while waiting for ToolchainStatus to contain error due to invalid console route")
 
 		t.Run("verify member and toolchain status go back to ready", func(t *testing.T) {
-			// change che required flag back to true to resolve the error on the memberstatus
-			memberConfigurationWithCheRequired = testconfig.ModifyMemberOperatorConfigObj(memberAwait.GetMemberOperatorConfig(t), testconfig.Che().Required(false))
-			hostAwait.UpdateToolchainConfig(t, testconfig.Members().Default(memberConfigurationWithCheRequired.Spec))
+			// change console route name back to default to resolve the error on the memberstatus
+			memberConfigurationWithValidConsole := testconfig.ModifyMemberOperatorConfigObj(memberAwait.GetMemberOperatorConfig(t), testconfig.Console().RouteName("console"))
+			hostAwait.UpdateToolchainConfig(t, testconfig.Members().Default(memberConfigurationWithValidConsole.Spec))
 
 			VerifyMemberStatus(t, memberAwait, consoleURL)
 			VerifyToolchainStatus(t, hostAwait, memberAwait)