test: increase timeout when waiting for deployment/registration-service in manage-devsandbox-dashboard.sh#1245
Conversation
WalkthroughA single timeout value is increased from 5 to 10 minutes for registration-service availability checks in the CI deployment script for the UI deployment path. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
scripts/ci/manage-devsandbox-dashboard.sh (1)
182-193: Consider increasing the route wait timeout for consistency.The deployment wait is now 10 minutes, but the route wait loop times out after ~2 minutes (60 iterations × 2 seconds). If the deployment takes close to the maximum time to become Available, the route might also need additional time to be ready. Consider increasing
NEXT_WAIT_TIMEthreshold or the sleep interval to provide more buffer.Example adjustment
NEXT_WAIT_TIME=0 - while [[ -z $(oc get routes registration-service -n ${HOST_NS} -o jsonpath='{.status.ingress[0].host}' 2>/dev/null || true) ]]; do - if [[ ${NEXT_WAIT_TIME} -eq 60 ]]; then + while [[ -z $(oc get routes registration-service -n ${HOST_NS} -o jsonpath='{.status.ingress[0].host}' 2>/dev/null || true) ]]; do + if [[ ${NEXT_WAIT_TIME} -eq 120 ]]; then echo "" echo "[$(date '+%Y-%m-%d %H:%M:%S')] ERROR: Timeout waiting for registration-service route" oc get routes -n ${HOST_NS}This would extend the route wait to ~4 minutes (120 iterations × 2 seconds).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/ci/manage-devsandbox-dashboard.sh
🔇 Additional comments (1)
scripts/ci/manage-devsandbox-dashboard.sh (1)
180-180: LGTM! Timeout increase addresses the timing issue.The change from 5 to 10 minutes appropriately addresses the race condition where the registration-service deployment is not Available within the original timeout window, as documented in the linked failure.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, rajivnathan, rsoaresd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Description
When running the e2e tests in devsandbox-dashboard, we are calling prepare-and-deploy-e2e test-devsandbox-dashboard-e2e . The route of registration-service could be not yet ready by the time we access https://github.com/codeready-toolchain/toolchain-e2e/blob/master/scripts/ci/manage-devsandbox-dashboard.sh#L180
I thought 5min will be enough but seems it is not: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/72470/rehearse-72470-pull-ci-codeready-toolchain-devsandbox-dashboard-master-e2e/2008583641336123392#1:build-log.txt%3A1260-1261. Test failed at
2026-01-06T18:02:14Z, deployment was available at2026-01-06T18:02:37ZSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.