test: improvements

[rsoaresd]

There was some suggestions in #1227 that we decided to address in a separated PR:

• move yum install section more up before copying the folder so it uses the cached snapshots: test: refactor pairing with UI code #1227 (comment)
• use go tool to install firefox: test: refactor pairing with UI code #1227 (comment)

Summary by CodeRabbit

• Chores
  • Improved Docker build performance through optimized layer caching strategy
  • Streamlined development environment setup by simplifying browser testing framework installation
  • Enhanced development tooling configuration for better build reliability

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The changes add a Playwright Go CLI tool directive to go.mod, simplify the Makefile's e2e-run-devsandbox-dashboard target to use go tool playwright for Firefox installation instead of explicit version handling, and reorder the Dockerfile COPY instruction to occur after dependency installation.

Changes

Cohort / File(s)	Summary
Build Configuration build/devsandbox-dashboard/Dockerfile	Reordered COPY instruction to execute after dependency installation rather than at the beginning, improving layer caching and build efficiency.
Go Dependency Management go.mod	Added tool directive for github.com/playwright-community/playwright-go/cmd/playwright to enable go tool installation of Playwright CLI.
Build Automation make/devsandbox-dashboard.mk	Simplified e2e-run-devsandbox-dashboard target by removing explicit version parsing and go install invocation, replacing with single go tool playwright install --with-deps command.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• alexeykazakov
• MatousJobanek
• xcoulon

Poem

🐰 Hops with glee, the build flows clean,
Playwright tools and Firefox seen,
Dependencies first, then copy done,
Layer caching speeds the run! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'test: improvements' is vague and generic, using the non-descriptive term 'improvements' without conveying specific information about what was improved.	Use a more descriptive title that specifies the improvements, such as 'test: optimize Dockerfile layer caching and use Go tool for Firefox installation' to better communicate the changeset.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb77a8e and e425386.

📒 Files selected for processing (3)

• build/devsandbox-dashboard/Dockerfile
• go.mod
• make/devsandbox-dashboard.mk

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: rsoaresd
Repo: codeready-toolchain/toolchain-e2e PR: 1232
File: make/devsandbox-dashboard.mk:57-57
Timestamp: 2025-12-11T16:29:34.403Z
Learning: In make/devsandbox-dashboard.mk, the test-devsandbox-dashboard-e2e-local target intentionally allows PUBLISH_UI=true and DEPLOY_UI=true to enable publishing and deploying when running locally (outside a container), while test-devsandbox-dashboard-in-container sets PUBLISH_UI=false because image pushing is not available from inside the container.

📚 Learning: 2025-12-11T16:29:34.403Z

Learnt from: rsoaresd
Repo: codeready-toolchain/toolchain-e2e PR: 1232
File: make/devsandbox-dashboard.mk:57-57
Timestamp: 2025-12-11T16:29:34.403Z
Learning: In make/devsandbox-dashboard.mk, the test-devsandbox-dashboard-e2e-local target intentionally allows PUBLISH_UI=true and DEPLOY_UI=true to enable publishing and deploying when running locally (outside a container), while test-devsandbox-dashboard-in-container sets PUBLISH_UI=false because image pushing is not available from inside the container.

Applied to files:

• make/devsandbox-dashboard.mk

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build & push operator bundles & dashboard image for e2e tests

🔇 Additional comments (3)

go.mod (1)

148-149: LGTM!

The tool directive is correctly used to declare the Playwright CLI as a Go tool, enabling go tool playwright commands. This aligns with Go 1.24's tool management feature and the playwright-go dependency already present at line 36.

build/devsandbox-dashboard/Dockerfile (1)

77-78: LGTM!

Placing COPY . . after dependency installation is a good Docker best practice. This optimizes layer caching since the dependency layers (yum install, Go installation) won't be invalidated when source code changes.

make/devsandbox-dashboard.mk (1)

35-36: LGTM!

Using go tool playwright install firefox is a cleaner approach that leverages the tool directive in go.mod. This eliminates dynamic version parsing and ensures version consistency with the playwright-go dependency.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[mfrancisc]

Nice 🤩

[MatousJobanek]

Thanks for addressing it 👍

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,mfrancisc,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment