fix: increase SSO login password field timeout to 60s#1287
Conversation
- After clicking "Next" on the Red Hat SSO page, the server validates the username before rendering the password form. This server-side call can be intermittently slow, causing the default 30s Playwright timeout to be exceeded (~25% failure rate in ci-daily-prod). - Add an explicit WaitFor with 60s timeout on the password field locator, matching the timeout already used for page navigation. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
WalkthroughIn the ChangesLogin synchronization fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d70f4e8
into
codeready-toolchain:master
|
@fbm3307: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



The ci-jobs have been failing intermittently with a Playwright timeout at
login.go:78when filling the password field after clicking "Next" on the Red Hat SSO login page.After clicking "Next", the SSO server validates the username server-side before rendering the password form. This call can be intermittently slow, exceeding the default 30s Playwright timeout.
TestActivitiesPagefailed atlogin.go:78TestActivitiesPagepassed butTestFreshSignupfailed at the samelogin.go:78Fix: Add an explicit
WaitFor(visible)with a 60s timeout on the password field locator after the "Next" click, matching the timeout already used forNavigate().Summary by CodeRabbit