add libX11-xcb to openshift-ci/Dockerfile.tools and build/sandbox-ui/Dockerfile

[rsoaresd]

Description

#1180 is failing with:

/go/src/github.com/codeready-toolchain/toolchain-e2e/test/e2e/sandbox-ui/activities_page_test.go:15
        	Error:      	Received unexpected error:
        	            	playwright: 
        	            	╔══════════════════════════════════════════════════════╗
        	            	║ Host system is missing dependencies to run browsers. ║
        	            	║ Please install them with the following command:      ║
        	            	║                                                      ║
        	            	║     sudo npx playwright install-deps                 ║
        	            	║                                                      ║
        	            	║ Alternatively, use apt:                              ║
        	            	║     sudo apt-get install libx11-xcb1                 ║
        	            	║                                                      ║
        	            	║ <3 Playwright Team                                   ║
        	            	╚══════════════════════════════════════════════════════╝
        	Test:       	TestActivitiesPage

We would need to add libX11-xcb to openshift-ci/Dockerfile.tools and build/sandbox-ui/Dockerfile. I am opening this PR cause I updated openshift-ci/Dockerfile.tools on #1180, but it seems not to be reflected because the config gets the openshift-ci/Dockerfile.tools from master: https://github.com/openshift/release/blob/master/ci-operator/config/codeready-toolchain/toolchain-e2e/codeready-toolchain-toolchain-e2e-master.yaml#L62

Summary by CodeRabbit

• Bug Fixes

  • Resolved Firefox startup issues in containerized environments by adding a missing system dependency, improving reliability for browser-based workflows.

• Chores

  • Updated build and CI container images to include the new dependency, ensuring consistent behavior across development and testing pipelines.

[coderabbitai]

Walkthrough

Adds libX11-xcb to Firefox-related dependencies in two Dockerfiles and adjusts line continuations so yum clean all remains chained after installation. No other commands, control flow, or public interfaces are changed.

Changes

Cohort / File(s)	Summary
Docker build dependencies build/sandbox-ui/Dockerfile, openshift-ci/Dockerfile.tools	Insert libX11-xcb into the yum install list for Firefox dependencies; tweak line breaks/continuations so installation and yum clean all remain within the same RUN step; no other modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled through Docker with whiskers of vim,
Dropped libX11-xcb on a dependency whim.
Fonts and foxes now render just right,
Cleaned up with yum in a tidy byte.
Thump goes my paw—builds hop into light! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title accurately and concisely summarizes the main change: adding libX11-xcb to both openshift-ci/Dockerfile.tools and build/sandbox-ui/Dockerfile, which matches the PR objectives and the file-level summaries. It is specific and clear enough for a teammate to understand the primary intent of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

openshift-ci/Dockerfile.tools (1)

54-56: LGTM: mirrored addition of libX11-xcb keeps both Dockerfiles in sync for Playwright/Firefox.

Good placement and continuation; cleanup still runs.

To avoid future drift between these two Dockerfiles, consider factoring the shared “Firefox deps” list into a build arg or a shared base image used by both.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 446c2d0 and 71ff819.

📒 Files selected for processing (2)

• build/sandbox-ui/Dockerfile (1 hunks)
• openshift-ci/Dockerfile.tools (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Unit Tests
• GitHub Check: GolangCI Lint
• GitHub Check: Build & push operator bundles for e2e tests
• GitHub Check: Build & push Developer Sandbox UI image for UI e2e tests

🔇 Additional comments (1)

build/sandbox-ui/Dockerfile (1)

86-88: LGTM: libX11-xcb added to Firefox deps fixes Playwright’s missing host library.

Package name matches UBI9 repos and chaining to yum clean all is preserved.

Please confirm CI actually rebuilds this image (prow sometimes uses cached layers). If needed, force a rebuild in your job and verify rpm -q libX11-xcb inside the container.

[MatousJobanek]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, mfrancisc, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,mfrancisc,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment