Skip to content

feat: return email in signup response #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfrancisc merged 9 commits into from
Oct 31, 2025
Merged

feat: return email in signup response #1217

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4e1bd38
check email in signup response
Oct 20, 2025
28cc46d
fix check
Oct 21, 2025
4a6054c
Merge branch 'master' into sendemailtoui
mfrancisc Oct 21, 2025
a300cc5
Merge branch 'master' into sendemailtoui
mfrancisc Oct 27, 2025
8a3cdf2
attempt to fix install operator flag
Oct 27, 2025
dc4b1a5
Merge branch 'master' into sendemailtoui
mfrancisc Oct 29, 2025
6e4ef6c
revert install operator flag
Oct 29, 2025
42bd883
Update make/test.mk
mfrancisc Oct 30, 2025
6b3a084
Update make/test.mk
mfrancisc Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions make/test.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ e2e-migration-verify:
@echo "Migration tests successfully finished"

.PHONY: e2e-deploy-latest
e2e-deploy-latest:
Comment thread
mfrancisc marked this conversation as resolved.
Outdated
e2e-deploy-latest:
$(MAKE) get-publish-install-and-register-operators MEMBER_NS=${MEMBER_NS} MEMBER_NS_2=${MEMBER_NS_2} HOST_NS=${HOST_NS} REGISTRATION_SERVICE_NS=${REGISTRATION_SERVICE_NS} ENVIRONMENT=${ENVIRONMENT} INSTALL_OPERATOR=${INSTALL_OPERATOR} DEPLOY_LATEST=true KSCTL_TLS_VERIFY_PARAM=${KSCTL_TLS_VERIFY_PARAM}

Expand Down Expand Up @@ -313,6 +314,7 @@ get-publish-install-and-register-operators: get-and-publish-host-operator get-an
# The reason is that when the host operator is installed, then the logic creates ToolchainConfig CR which
# defines that the webhook should be deployed from the first member instance (and not from the second one).
# This is important to set before the member operators are installed, otherwise, it can lead to flaky e2e tests.
get-publish-and-install-operators:
Comment thread
mfrancisc marked this conversation as resolved.
Outdated
get-publish-and-install-operators: get-and-publish-host-operator create-host-resources get-and-publish-member-operator

.PHONY: get-and-publish-member-operator
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/parallel/registration_service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,7 @@ func TestSignupOK(t *testing.T) {
"username": userSignup.Spec.IdentityClaims.PreferredUsername,
"givenName": userSignup.Spec.IdentityClaims.GivenName,
"familyName": userSignup.Spec.IdentityClaims.FamilyName,
"email": emailAddress,
"userID": "123",
"accountID": "456",
"accountNumber": "789",
Expand Down Expand Up @@ -1036,7 +1037,7 @@ func signupHasExpectedClaims(claims map[string]string) func(c *GetSignupClient)
return func(c *GetSignupClient) {
for expectedClaim, expectedClaimValue := range claims {
actualClaimValue, claimFound := c.responseBody[expectedClaim]
require.True(c.t, claimFound, "unable to find expected claim [%s]. Claims found %v", expectedClaim, claims)
require.True(c.t, claimFound, "unable to find expected claim [%s]. Claims found %v", expectedClaim, c.responseBody)
require.Equal(c.t, expectedClaimValue, actualClaimValue, "expected claim value [%s] doesn't match actual claim value [%s]", expectedClaimValue, actualClaimValue)
}
}
Expand Down
Loading