Skip to content

test: rename sandbox-ui to devsandbox-dashboard#1229

Merged
rsoaresd merged 4 commits intocodeready-toolchain:masterfrom
rsoaresd:rename_sandbox-ui_to_devsandbox-dashboard
Dec 10, 2025
Merged

test: rename sandbox-ui to devsandbox-dashboard#1229
rsoaresd merged 4 commits intocodeready-toolchain:masterfrom
rsoaresd:rename_sandbox-ui_to_devsandbox-dashboard

Conversation

@rsoaresd
Copy link
Copy Markdown
Contributor

@rsoaresd rsoaresd commented Dec 9, 2025

Description

Rename sandbox-ui to devsandbox-dashboard. Not done previously in #1227 to not difficult the review

Issue ticket number and link

SANDBOX-1511

Summary by CodeRabbit

  • Chores
    • Updated internal test and build configuration to use the new devsandbox-dashboard test target and environment.
  • Tests
    • Migrated end-to-end test suite and CI deployment references to the devsandbox-dashboard setup to ensure E2E runs and tracing use the updated test area.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci openshift-ci Bot requested review from metlos and rajivnathan December 9, 2025 14:15
@openshift-ci openshift-ci Bot added the approved label Dec 9, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 9, 2025

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (10)
  • deploy/devsandbox-dashboard/base/deployment.yaml
  • deploy/devsandbox-dashboard/base/kustomization.yaml
  • deploy/devsandbox-dashboard/base/route.yaml
  • deploy/devsandbox-dashboard/base/service-accounts.yaml
  • deploy/devsandbox-dashboard/base/service.yaml
  • deploy/devsandbox-dashboard/ui-e2e-tests/.env
  • deploy/devsandbox-dashboard/ui-e2e-tests/app-config.yaml
  • deploy/devsandbox-dashboard/ui-e2e-tests/dynamic-plugins.yaml
  • deploy/devsandbox-dashboard/ui-e2e-tests/kustomization.yaml
  • deploy/devsandbox-dashboard/ui-e2e-tests/oauth-idp-patch.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Refactors repository references from sandbox-ui to devsandbox-dashboard across CI scripts, Makefile targets, .gitignore, e2e tests, and testsupport utilities, updating file paths, import aliases, Dockerfile reference, and environment/artifact paths without changing core logic.

Changes

Cohort / File(s) Summary
Repository ignore
\.gitignore
Changed ignored env path from testsupport/sandbox-ui/.env to testsupport/devsandbox-dashboard/.env
Build & CI
make/devsandbox-dashboard\.mk, scripts/ci/manage-devsandbox-dashboard\.sh
Updated Make targets, namespaces, E2E invocation paths, env prep path, cleanup vars, and Dockerfile/kustomize/deploy paths from sandbox-ui to devsandbox-dashboard
E2E tests
test/e2e/devsandbox-dashboard/*_test\.go
test/e2e/devsandbox-dashboard/activities_page_test.go, test/e2e/devsandbox-dashboard/header_test.go, test/e2e/devsandbox-dashboard/homepage_test.go
Repointed import aliases to use devsandbox-dashboard test support package instead of sandbox-ui (no test logic changes)
Test support
testsupport/devsandbox-dashboard/*
testsupport/devsandbox-dashboard/setup.go, testsupport/devsandbox-dashboard/trace.go
Updated viper config/env file path and CI artifact/trace path to use devsandbox-dashboard directory

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are repetitive path/import updates across related files.
  • Pay attention to:
    • make/devsandbox-dashboard.mk (target names, env propagation, Dockerfile path)
    • scripts/ci/manage-devsandbox-dashboard.sh (kustomize and oauth-idp patch paths)
    • Test import aliases to ensure module paths resolve correctly in go.mod

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • rajivnathan
  • metlos
  • jrosental
  • mfrancisc

Poem

🐰 I hopped through paths both near and far,
Moved sandbox echoes to a brand new star,
Imports aligned and envs in tow,
Tests now find the routes to go,
A tiny hop — devdashboard, here we are! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: renaming 'sandbox-ui' to 'devsandbox-dashboard' across test files and configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@rsoaresd rsoaresd merged commit b54a4e3 into codeready-toolchain:master Dec 10, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants