Skip to content

test: improve how we set PUBLISH_UI #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsoaresd merged 3 commits into from
Dec 15, 2025
Merged

test: improve how we set PUBLISH_UI #1233

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cf3082
improve
rsoaresd Dec 11, 2025
a6a3377
requested changes
rsoaresd Dec 11, 2025
7642cb3
Merge branch 'master' into improve_PUBLISH_UI_configuration
rsoaresd Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions make/devsandbox-dashboard.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,14 @@ UI_ENVIRONMENT := ui-e2e-tests
SSO_USERNAME_READ := $(shell if [ -n "$(CI)" ]; then cat /usr/local/sandbox-secrets/SSO_USERNAME 2>/dev/null || echo ""; else echo "${SSO_USERNAME}"; fi)
SSO_PASSWORD_READ := $(shell if [ -n "$(CI)" ]; then cat /usr/local/sandbox-secrets/SSO_PASSWORD 2>/dev/null || echo ""; else echo "${SSO_PASSWORD}"; fi)


PUBLISH_UI ?= false
PUBLISH_UI ?= true
Copy link
Copy Markdown
Contributor

@rajivnathan rajivnathan Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be the other way around? false by default but if CLONEREFS_OPTIONS then set it to true?

Copy link
Copy Markdown
Contributor Author

@rsoaresd rsoaresd Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running in CI (CLONEREFS_OPTIONS set), we want PUBLISH_UI to false. Because we will push it in a GH action through this make target: https://github.com/codeready-toolchain/toolchain-e2e/blob/master/make/test.mk#L295-L304

Copy link
Copy Markdown
Contributor

@rajivnathan rajivnathan Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, thanks for the explanation

DEPLOY_UI ?= true

ifneq ($(CLONEREFS_OPTIONS),)
PUBLISH_UI = false
endif


.PHONY: get-and-publish-devsandbox-dashboard
get-and-publish-devsandbox-dashboard:
ifneq (${UI_REPO_PATH},)
Expand Down Expand Up @@ -49,7 +53,7 @@ test-devsandbox-dashboard-e2e: get-and-publish-devsandbox-dashboard e2e-run-devs

.PHONY: test-devsandbox-dashboard-e2e-local
test-devsandbox-dashboard-e2e-local:
$(MAKE) get-and-publish-devsandbox-dashboard e2e-run-devsandbox-dashboard UI_REPO_PATH=${PWD}/../devsandbox-dashboard PUBLISH_UI=true DEPLOY_UI=true
$(MAKE) get-and-publish-devsandbox-dashboard e2e-run-devsandbox-dashboard UI_REPO_PATH=${PWD}/../devsandbox-dashboard

.PHONY: clean-devsandbox-dashboard
clean-devsandbox-dashboard: HOST_NS=$(shell oc get projects -l app=host-operator --output=name -o jsonpath='{range .items[*]}{.metadata.name}{"\n"}{end}' | sort | tail -n 1)
Expand Down
Loading