Skip to content

test: increase timeout when waiting for deployment/registration-service in manage-devsandbox-dashboard.sh#1245

Merged
rsoaresd merged 3 commits into
codeready-toolchain:masterfrom
rsoaresd:increase_timeout
Jan 6, 2026
Merged

test: increase timeout when waiting for deployment/registration-service in manage-devsandbox-dashboard.sh#1245
rsoaresd merged 3 commits into
codeready-toolchain:masterfrom
rsoaresd:increase_timeout

Conversation

@rsoaresd
Copy link
Copy Markdown
Contributor

@rsoaresd rsoaresd commented Jan 6, 2026

Description

When running the e2e tests in devsandbox-dashboard, we are calling prepare-and-deploy-e2e test-devsandbox-dashboard-e2e . The route of registration-service could be not yet ready by the time we access https://github.com/codeready-toolchain/toolchain-e2e/blob/master/scripts/ci/manage-devsandbox-dashboard.sh#L180

I thought 5min will be enough but seems it is not: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/72470/rehearse-72470-pull-ci-codeready-toolchain-devsandbox-dashboard-master-e2e/2008583641336123392#1:build-log.txt%3A1260-1261. Test failed at 2026-01-06T18:02:14Z, deployment was available at 2026-01-06T18:02:37Z

Summary by CodeRabbit

  • Chores
    • Enhanced deployment infrastructure reliability by extending service initialization wait time during deployments.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 6, 2026

Walkthrough

A single timeout value is increased from 5 to 10 minutes for registration-service availability checks in the CI deployment script for the UI deployment path.

Changes

Cohort / File(s) Summary
Timeout Configuration
scripts/ci/manage-devsandbox-dashboard.sh
Extended registration-service availability wait timeout from 5 to 10 minutes in the UI deployment flow

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • toolchain-e2e#1240: Modifies the same script and adjusts registration-service readiness logic alongside this timeout extension.

Suggested labels

lgtm

Suggested reviewers

  • alexeykazakov
  • xcoulon
  • metlos

Poem

🐰 A patient bunny waits ten minutes long,
For services to register, steady and strong,
Five to ten—a doubling of grace,
Giving deployments more time and space! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: increasing a timeout for the registration-service availability wait in the manage-devsandbox-dashboard.sh script, which aligns with the changeset.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 6, 2026

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
scripts/ci/manage-devsandbox-dashboard.sh (1)

182-193: Consider increasing the route wait timeout for consistency.

The deployment wait is now 10 minutes, but the route wait loop times out after ~2 minutes (60 iterations × 2 seconds). If the deployment takes close to the maximum time to become Available, the route might also need additional time to be ready. Consider increasing NEXT_WAIT_TIME threshold or the sleep interval to provide more buffer.

Example adjustment
     NEXT_WAIT_TIME=0
-    while [[ -z $(oc get routes registration-service -n ${HOST_NS} -o jsonpath='{.status.ingress[0].host}' 2>/dev/null || true) ]]; do
-        if [[ ${NEXT_WAIT_TIME} -eq 60 ]]; then
+    while [[ -z $(oc get routes registration-service -n ${HOST_NS} -o jsonpath='{.status.ingress[0].host}' 2>/dev/null || true) ]]; do
+        if [[ ${NEXT_WAIT_TIME} -eq 120 ]]; then
             echo ""
             echo "[$(date '+%Y-%m-%d %H:%M:%S')] ERROR: Timeout waiting for registration-service route"
             oc get routes -n ${HOST_NS}

This would extend the route wait to ~4 minutes (120 iterations × 2 seconds).

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d83fe9 and 4fd7cf3.

📒 Files selected for processing (1)
  • scripts/ci/manage-devsandbox-dashboard.sh
🔇 Additional comments (1)
scripts/ci/manage-devsandbox-dashboard.sh (1)

180-180: LGTM! Timeout increase addresses the timing issue.

The change from 5 to 10 minutes appropriately addresses the race condition where the registration-service deployment is not Available within the original timeout window, as documented in the linked failure.

@rsoaresd rsoaresd changed the title test: increase timeout test: increase timeout when waiting for deployment/registration-service in manage-devsandbox-dashboard.sh Jan 6, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,rajivnathan,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsoaresd rsoaresd merged commit 6612961 into codeready-toolchain:master Jan 6, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants