Skip to content

SANDBOX-1568: fix flaky TestActivationCodeVerification/over_capacity test #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsoaresd merged 4 commits into from
Jan 14, 2026
Merged

SANDBOX-1568: fix flaky TestActivationCodeVerification/over_capacity test #1247

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd2260a
fix flaky TestActivationCodeVerification/over_capacity test
rsoaresd Jan 12, 2026
e633bd7
Merge branch 'master' into wait_for_social_event
rsoaresd Jan 12, 2026
64533f5
add detailed comment
rsoaresd Jan 13, 2026
bac6891
Merge branch 'master' into wait_for_social_event
rsoaresd Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions test/e2e/parallel/registration_service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,11 @@ func TestActivationCodeVerification(t *testing.T) {
event := testsocialevent.NewSocialEvent(hostAwait.Namespace, commonsocialevent.NewName(),
testsocialevent.WithUserTier("deactivate80"),
testsocialevent.WithSpaceTier("base1ns6didler"),
// MaxAttendees is set to 0 to simulate event being already full
// We use this approach instead of manipulating ActivationCount to avoid flakiness
// if the controller reconciliation is triggered by other parallel test, the ActivationCount
// would be recalculated to 0 (due to the counting of approved UserSignups) and the test would fail.
testsocialevent.WithMaxAttendees(0),
testsocialevent.WithTargetCluster(member2Await.ClusterName))
err := hostAwait.CreateWithCleanup(t, event)
require.NoError(t, err)
Expand All @@ -862,12 +867,6 @@ func TestActivationCodeVerification(t *testing.T) {
Status: corev1.ConditionTrue,
})) // need to reload event
require.NoError(t, err)
event, err = wait.For(t, hostAwait.Awaitility, &toolchainv1alpha1.SocialEvent{}).
UpdateStatus(event.Name, hostAwait.Namespace,
func(ev *toolchainv1alpha1.SocialEvent) {
ev.Status.ActivationCount = event.Spec.MaxAttendees // activation count identical to `MaxAttendees`
})
require.NoError(t, err)

userSignup, token := signup(t, hostAwait)

Expand Down
Loading