Skip to content

Remove unused DurationBeforeChangeTierRequestDeletion config #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajivnathan merged 4 commits into from
Feb 26, 2026
Merged

Remove unused DurationBeforeChangeTierRequestDeletion config #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9972be0
Remove unused DurationBeforeChangeTierRequestDeletion config
rajivnathan Feb 25, 2026
fcec415
Merge branch 'master' of github.com:codeready-toolchain/toolchain-e2e…
rajivnathan Feb 26, 2026
7fb0692
Update deps
rajivnathan Feb 26, 2026
bc0f431
Remove durationBeforeChangeTierRequestDeletion from test config files
rajivnathan Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion deploy/host-operator/appstudio-e2e/toolchainconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ spec:
tiers:
defaultTier: 'appstudio'
defaultSpaceTier: 'appstudio'
durationBeforeChangeTierRequestDeletion: '5s'
automaticApproval:
enabled: true
deactivation:
Expand Down
1 change: 0 additions & 1 deletion deploy/host-operator/e2e-tests/toolchainconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ spec:
spaceRequestEnabled: true
spaceBindingRequestEnabled: true
tiers:
durationBeforeChangeTierRequestDeletion: '5s'
defaultSpaceTier: 'base1ns'
featureToggles:
- name: "test-feature"
Expand Down
1 change: 0 additions & 1 deletion deploy/host-operator/ui-e2e-tests/toolchainconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ spec:
spaceRequestEnabled: true
spaceBindingRequestEnabled: true
tiers:
durationBeforeChangeTierRequestDeletion: "5s"
defaultSpaceTier: "base1ns"
featureToggles:
- name: "test-feature"
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/codeready-toolchain/toolchain-e2e

require (
github.com/codeready-toolchain/api v0.0.0-20260108115150-4c6695ed18de
github.com/codeready-toolchain/toolchain-common v0.0.0-20260225205316-85e4bef507f2
github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7
Copy link
Copy Markdown
Contributor

@rsoaresd rsoaresd Feb 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete durationBeforeChangeTierRequestDeletion in the deploy/host-operator toolchainconfig.yml files?

Copy link
Copy Markdown
Contributor Author

@rajivnathan rajivnathan Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you! Great catch! You are better than coderabbit! 😁 bc0f431

github.com/codeready-toolchain/toolchain-common v0.0.0-20260226040150-d7d5d0163ff7
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc
github.com/fatih/color v1.18.0
github.com/ghodss/yaml v1.0.0
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMn
github.com/cloudflare/circl v1.1.0/go.mod h1:prBCrKB9DV4poKZY1l9zBXg2QJY7mvgRvtMxxK7fi4I=
github.com/cloudflare/circl v1.6.3 h1:9GPOhQGF9MCYUeXyMYlqTR6a5gTrgR/fBLXvUgtVcg8=
github.com/cloudflare/circl v1.6.3/go.mod h1:2eXP6Qfat4O/Yhh8BznvKnJ+uzEoTQ6jVKJRn81BiS4=
github.com/codeready-toolchain/api v0.0.0-20260108115150-4c6695ed18de h1:rc39ZRUk2AyADzH+bt5On7V7qJz6syUrI4qNyCSXY3o=
github.com/codeready-toolchain/api v0.0.0-20260108115150-4c6695ed18de/go.mod h1:O/HyAcz6fynt3LXr8wTGaIXt+0v6BpkiJvDxNQDCqyA=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260225205316-85e4bef507f2 h1:Cn60rNw0cK4GrtJdTbaDfBr9Nbl0gIGRwrV4raSzM6o=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260225205316-85e4bef507f2/go.mod h1:ZiaHcxOYExpyzOwIQjpggJm9LvcdNsxCMF+qrXOVkr0=
github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7 h1:1YCopXDF7WSjhM7sQAFoNeJvoIVPCHDY35jNVqc0Xh4=
github.com/codeready-toolchain/api v0.0.0-20260226033043-912fcbd23dc7/go.mod h1:PMg6kNHuCGNlu3MOdrCisqGkBpvzB0qS1+E6nrXxPAc=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260226040150-d7d5d0163ff7 h1:NLTKW/An6PfcgqUyjeloAl0cmR0/lJopURsMMY/VZcs=
github.com/codeready-toolchain/toolchain-common v0.0.0-20260226040150-d7d5d0163ff7/go.mod h1:TtwbNKTtHxDEaO2fOhJbYM4S1FykJHOf/4/nCw7hFwo=
github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
Expand Down
Loading