Skip to content

fix: increase SSO login password field timeout to 60s#1287

Merged
openshift-merge-bot[bot] merged 1 commit into
codeready-toolchain:masterfrom
fbm3307:fix/sso-login-password-timeout
Jun 18, 2026
Merged

fix: increase SSO login password field timeout to 60s#1287
openshift-merge-bot[bot] merged 1 commit into
codeready-toolchain:masterfrom
fbm3307:fix/sso-login-password-timeout

Conversation

@fbm3307

@fbm3307 fbm3307 commented Jun 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

The ci-jobs have been failing intermittently with a Playwright timeout at login.go:78 when filling the password field after clicking "Next" on the Red Hat SSO login page.

After clicking "Next", the SSO server validates the username server-side before rendering the password form. This call can be intermittently slow, exceeding the default 30s Playwright timeout.

  • June 12 failure — TestActivitiesPage failed at login.go:78
  • June 14 failure — TestActivitiesPage passed but TestFreshSignup failed at the same login.go:78

Fix: Add an explicit WaitFor(visible) with a 60s timeout on the password field locator after the "Next" click, matching the timeout already used for Navigate().

Summary by CodeRabbit

  • Tests
    • Enhanced login test synchronization to improve reliability during the authentication flow.

@fbm3307 @cursoragent
fix: increase SSO login password field timeout to 60s
4b00c87 
- After clicking "Next" on the Red Hat SSO page, the server validates
  the username before rendering the password form. This server-side
  call can be intermittently slow, causing the default 30s Playwright
  timeout to be exceeded (~25% failure rate in ci-daily-prod).
- Add an explicit WaitFor with 60s timeout on the password field
  locator, matching the timeout already used for page navigation.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@openshift-ci openshift-ci Bot requested review from mfrancisc and rsoaresd June 18, 2026 09:34
@sonarqubecloud

sonarqubecloud Bot commented Jun 18, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@coderabbitai

coderabbitai Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 3c31826d-c93e-4394-b275-691c18bca06b

📥 Commits

Reviewing files that changed from the base of the PR and between 6924f8a and 4b00c87.

📒 Files selected for processing (1)
  • testsupport/devsandbox-dashboard/login.go
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • codeready-toolchain/api (manual)
  • codeready-toolchain/toolchain-common (manual)
  • codeready-toolchain/host-operator (manual)
  • codeready-toolchain/toolchain-e2e (manual)
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build & push operator bundles & dashboard image for e2e tests
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • testsupport/devsandbox-dashboard/login.go
🔇 Additional comments (1)
testsupport/devsandbox-dashboard/login.go (1)

76-83: LGTM!

Walkthrough

In the Login function, a synchronization step is added for DevEnv/ProdEnv environments: after clicking the Next button, the code now explicitly waits up to 60 seconds for the password field (LoginPwLoc) to become visible before proceeding, and asserts no error on that wait.

Changes

Login synchronization fix

Layer / File(s) Summary
Post-Next password field visibility wait
testsupport/devsandbox-dashboard/login.go		 After the Next button click in the DevEnv/ProdEnv branch, waits for LoginPwLoc to reach visible state with a 60s timeout; enforces the wait result with require.NoError before filling the password.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

bug, test

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an explicit 60-second timeout to the SSO login password field validation, which is the core fix addressing intermittent CI failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added bug Something isn't working test Work that adds, fixes, or maintains automated tests or coverage (unit, integration, e2e, flakiness) labels Jun 18, 2026
MatousJobanek
MatousJobanek approved these changes Jun 18, 2026
View reviewed changes

@MatousJobanek MatousJobanek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 18, 2026
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit d70f4e8 into codeready-toolchain:master Jun 18, 2026
10 checks passed
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

@fbm3307: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 4b00c87 link unknown /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MatousJobanek MatousJobanek MatousJobanek approved these changes
@mfrancisc mfrancisc Awaiting requested review from mfrancisc
@rsoaresd rsoaresd Awaiting requested review from rsoaresd

Assignees

@MatousJobanek MatousJobanek

Labels

approved bug Something isn't working lgtm test Work that adds, fixes, or maintains automated tests or coverage (unit, integration, e2e, flakiness)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fbm3307 @MatousJobanek