Skip to content

Commit d4b6ca4

Browse files
authored
Minify included JavaScript (#704)
Provide minified versions of JavaScript files. The project has a minimal amount of JavaScript, so a simple tool is included to minify them rather than pulling in a full build tool. This will help with SEO tools penalizing for unminified scripts, despite their small size.
1 parent b59625c commit d4b6ca4

12 files changed

Lines changed: 58 additions & 5 deletions

File tree

coderedcms/static/coderedcms/js/crx-editor.min.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderedcms/static/coderedcms/js/crx-events.min.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderedcms/static/coderedcms/js/crx-front.min.js

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderedcms/static/coderedcms/js/crx-maps.min.js

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderedcms/static/coderedcms/js/crx-streamforms.min.js

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

coderedcms/templates/coderedcms/pages/base.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ <h2 class="text-center my-5">{% trans "Related" %}</h2>
176176
{% endblock %}
177177

178178
{% block coderedcms_scripts %}
179-
<script src="{% static 'coderedcms/js/crx-front.js' %}?v={% coderedcms_version %}"></script>
179+
<script src="{% static 'coderedcms/js/crx-front.min.js' %}?v={% coderedcms_version %}"></script>
180180
{% endblock %}
181181

182182
{% block custom_scripts %}{% endblock %}

coderedcms/templates/coderedcms/pages/event_index_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,5 @@
3333
{{ block.super }}
3434
<script src="https://cdn.jsdelivr.net/npm/fullcalendar@6.1.15/index.global.min.js" integrity="sha256-ZztCtsADLKbUFK/X6nOYnJr0eelmV2X3dhLDB/JK6fM=" crossorigin="anonymous"></script>
3535
<script src="https://cdn.jsdelivr.net/npm/@fullcalendar/bootstrap5@6.1.15/index.global.min.js" integrity="sha256-TslkUnYKZuqQj4Ueu1WQesikFvl2DADWslCx3EfBHZM=" crossorigin="anonymous"></script>
36-
<script src="{% static 'coderedcms/js/crx-events.js' %}?v={% coderedcms_version %}"></script>
36+
<script src="{% static 'coderedcms/js/crx-events.min.js' %}?v={% coderedcms_version %}"></script>
3737
{% endblock %}

coderedcms/templates/coderedcms/pages/location_index_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@
3838
{% endblock %}
3939
{% block coderedcms_scripts %}
4040
{{ block.super }}
41-
<script src="{% static 'coderedcms/js/crx-maps.js' %}?v={% coderedcms_version %}"></script>
41+
<script src="{% static 'coderedcms/js/crx-maps.min.js' %}?v={% coderedcms_version %}"></script>
4242
<script defer src="https://maps.googleapis.com/maps/api/js?key={{ google_api_key }}&callback=initMap&libraries=places"></script>
4343
{% endblock %}

coderedcms/templates/coderedcms/pages/stream_form_page.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,5 @@
5757
{% block coderedcms_scripts %}
5858
{{ block.super }}
5959
<script src="https://cdn.jsdelivr.net/npm/jquery@3.7.1/dist/jquery.min.js" integrity="sha256-/JqT3SQfawRcv/BIHPThkBvs0OEvtFFmqPF/lYI/Cxo=" crossorigin="anonymous"></script>
60-
<script src="{% static 'coderedcms/js/crx-streamforms.js' %}?v={% coderedcms_version %}"></script>
60+
<script src="{% static 'coderedcms/js/crx-streamforms.min.js' %}?v={% coderedcms_version %}"></script>
6161
{% endblock %}

docs/contributing/index.rst

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ license header comment states copyright, ownership, license, and also provides c
112112
113113
/*!
114114
Wagtail CRX (https://www.coderedcorp.com/cms/)
115-
Copyright 2018-2023 CodeRed LLC
115+
Copyright 2018-2025 CodeRed LLC
116116
License: https://github.com/coderedcorp/coderedcms/blob/main/LICENSE
117117
@license magnet:?xt=urn:btih:c80d50af7d3db9be66a4d0a86db0286e4fd33292&dn=bsd-3-clause.txt BSD-3-Clause
118118
*/
@@ -121,6 +121,12 @@ license header comment states copyright, ownership, license, and also provides c
121121
122122
/* @license-end */
123123
124+
When editing JavaScript files, be sure to minify them. The minified files must also be committed to version control as they are distributed as part of our package.
125+
126+
.. code-block:: console
127+
128+
$ python minify.py
129+
124130
125131
Upgrading 3rd-Party CSS/JavaScript Libraries
126132
--------------------------------------------

0 commit comments

Comments
 (0)