Multisite navs#408
Merged
Merged
Conversation
added 2 commits
February 25, 2021 17:29
…bar and get_footer functions, fixed templates to render the choices, also setting for what to do if no site navbar or footer is chosen
vsalvino
reviewed
Mar 1, 2021
added 8 commits
March 1, 2021 13:53
…vbars, get_footers and templates
… the best and looks the best in Settings but still not able to actually grab and loop through the navbars in the template. Tutorial I used: https://learnwagtail.com/tutorials/how-use-orderables-wagtail-cms/ Also, Page is a ClusterableModel and that's why I made LayoutSettings a ClusterableModel so that the Orderable connection would work.
…ooter instance within the orderable, adjusted template for footer to loop through footers, new single migration
Contributor
Author
|
@vsalvino Ready for another full review. Then show me how to write a manual migration please. |
vsalvino
reviewed
Mar 16, 2021
added 6 commits
March 16, 2021 12:07
…ngs. Need to pull in instances - but want to only pull in current navbars/footers, not all future navs/footers that may be added to snippets if this migration ends up being run again or if we have manually separated the navs in a template for a specific site - so how to loop through only current instances once and add them to layout? will this migration be run each time you migrate - because it will produce duplicates if so - so how to specify only run it this one time?
…s and not to run if new site, fixed template tags for getting navbars and footers and rendering the correct sort order
Contributor
Author
|
NOTES TO SELF: Next steps are to add unit tests and documentation. |
added 6 commits
July 30, 2021 17:52
…s and not to run if new site, fixed template tags for getting navbars and footers and rendering the correct sort order
added 7 commits
January 14, 2022 10:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Documentation
Updated docs with the change.
Tests
Manual testing after migrating: Create a navbar and footer snippet and select them in the settings chooser. Make several to switch between snippets and also see what happens when no snippet is chosen. Add an additional site to Sites and select a navbar and footer for that site.