Skip to content

Refactor internal default settings#497

Merged
vsalvino merged 1 commit into
devfrom
crx-settings
Jun 9, 2022
Merged

Refactor internal default settings#497
vsalvino merged 1 commit into
devfrom
crx-settings

Conversation

@vsalvino
Copy link
Copy Markdown
Contributor

@vsalvino vsalvino commented Jun 9, 2022

This effectively fixes #8

  • Refactored internal settings to behave more like Django settings
  • Use this opportunity to rename stuff to crx_* for consistency.
  • Lazy load any settings being used as choices in concrete model fields. This will totally eliminate the issue of sites generating migrations back in coderedcms. It's a bit of a hack (that we were already employing elsewhere) but will be a good quality of life improvement until Make built-in models abstract #56 is completely implemented and we have no more concrete models (which may never even happen)

@vsalvino vsalvino added this to the 0.24.0 milestone Jun 9, 2022
@vsalvino vsalvino merged commit 5d11616 into dev Jun 9, 2022
@vsalvino vsalvino deleted the crx-settings branch June 9, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor FRONTEND_* settings

1 participant