Skip to content

Check for broken links#918

Closed
richelbilderbeek wants to merge 1 commit into
coderefinery:mainfrom
richelbilderbeek:main
Closed

Check for broken links#918
richelbilderbeek wants to merge 1 commit into
coderefinery:mainfrom
richelbilderbeek:main

Conversation

@richelbilderbeek

Copy link
Copy Markdown

Dear maintainer(s),

I've found some broken links on your website. However, as you seem comfortable using CI, here I submit a CI link checker. The scripts are used in many place, e.g. the UPPMAX documentation. To find broken links, search for error :-)

This PR will break the build, as it exposes some links that have become broken 👍

Cheers, Richel Bilderbeek

@bast

bast commented Jan 12, 2025

Copy link
Copy Markdown
Member

Thanks so much!

@bast

bast commented Jan 21, 2025

Copy link
Copy Markdown
Member

Sorry for taking some time to follow up. And I don't want to invalidate the good work and good effort but there might be an easier way for us here with zola check which does this without introducing external tools.

Advantages:

  • No extra tools.
  • It seems to understand better internal links which seem to trigger errors in the other workflow.

Currently 28 broken links, most of them in blog posts linking to links which expired.

@bast

bast commented Jan 21, 2025

Copy link
Copy Markdown
Member

But in any outcome we should I think check for broken links and also fix them now so I appreciate the initiative.

@bast

bast commented Feb 17, 2025

Copy link
Copy Markdown
Member

I am working on fixing broken links in #928.

@bast

bast commented Feb 22, 2025

Copy link
Copy Markdown
Member

My recommendation after doing the work in #928 is that we should check for broken links with "zola check" since it allows us to ignore certain patterns in config.toml:

# do not check blog posts for broken external links
ignored_files = [
"*/content/blog/*",
"*/content/open-house/*",
]

@samumantha

Copy link
Copy Markdown
Member

Do I understand correctly that "zola check" is now implemented in our build automation and therefore this PR can be closed?

@bast

bast commented Jul 8, 2025

Copy link
Copy Markdown
Member

Zola check is not run automatically. I ran it locally when working on #928. We should run it automatically.

@samumantha

Copy link
Copy Markdown
Member

Thanks again @richelbilderbeek for bringing this up! A check for broken links is indeed a good idea.
As discussed above we have implemented the link check now via zola in #938 . Therefore closing this PR.

@samumantha samumantha closed this Jul 9, 2025
@richelbilderbeek

Copy link
Copy Markdown
Author

@samumantha yes, I am happy the links are now checked (and I care less about a PR getting accepted: the goal of it has been reached). Well done and keep up the good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants