chore: Refactor bit_not (apache#2896)

Co-authored-by: Kazantsev Maksim <mn.kazantsev@gmail.com>

Author: kazantsev-maksim

native/core/src/execution/jni_api.rs

@@ -41,6 +41,7 @@ use datafusion::{
 };
 use datafusion_comet_proto::spark_operator::Operator;
 use datafusion_spark::function::bitwise::bit_get::SparkBitGet;
+use datafusion_spark::function::bitwise::bitwise_not::SparkBitwiseNot;
 use datafusion_spark::function::datetime::date_add::SparkDateAdd;
 use datafusion_spark::function::datetime::date_sub::SparkDateSub;
 use datafusion_spark::function::hash::sha1::SparkSha1;
@@ -335,6 +336,7 @@ fn register_datafusion_spark_function(session_ctx: &SessionContext) {
     session_ctx.register_udf(ScalarUDF::new_from_impl(SparkDateSub::default()));
     session_ctx.register_udf(ScalarUDF::new_from_impl(SparkSha1::default()));
     session_ctx.register_udf(ScalarUDF::new_from_impl(SparkConcat::default()));
+    session_ctx.register_udf(ScalarUDF::new_from_impl(SparkBitwiseNot::default()));
 }
 
 /// Prepares arrow arrays for output.

native/spark-expr/src/bitwise_funcs/bitwise_not.rs

@@ -16,7 +16,5 @@
 // under the License.
 
 mod bitwise_count;
-mod bitwise_not;
 
 pub use bitwise_count::SparkBitwiseCount;
-pub use bitwise_not::SparkBitwiseNot;

native/spark-expr/src/bitwise_funcs/mod.rs

@@ -22,8 +22,8 @@ use crate::math_funcs::modulo_expr::spark_modulo;
 use crate::{
     spark_array_repeat, spark_ceil, spark_decimal_div, spark_decimal_integral_div, spark_floor,
     spark_hex, spark_isnan, spark_lpad, spark_make_decimal, spark_read_side_padding, spark_round,
-    spark_rpad, spark_unhex, spark_unscaled_value, EvalMode, SparkBitwiseCount, SparkBitwiseNot,
-    SparkDateTrunc, SparkStringSpace,
+    spark_rpad, spark_unhex, spark_unscaled_value, EvalMode, SparkBitwiseCount, SparkDateTrunc,
+    SparkStringSpace,
 };
 use arrow::datatypes::DataType;
 use datafusion::common::{DataFusionError, Result as DataFusionResult};
@@ -195,7 +195,6 @@ pub fn create_comet_physical_fun_with_eval_mode(
 
 fn all_scalar_functions() -> Vec<Arc<ScalarUDF>> {
     vec![
-        Arc::new(ScalarUDF::new_from_impl(SparkBitwiseNot::default())),
         Arc::new(ScalarUDF::new_from_impl(SparkBitwiseCount::default())),
         Arc::new(ScalarUDF::new_from_impl(SparkDateTrunc::default())),
         Arc::new(ScalarUDF::new_from_impl(SparkStringSpace::default())),

native/spark-expr/src/comet_scalar_funcs.rs

@@ -46,7 +46,7 @@ object CometBitwiseNot extends CometExpressionSerde[BitwiseNot] {
       binding: Boolean): Option[ExprOuterClass.Expr] = {
     val childProto = exprToProto(expr.child, inputs, binding)
     val bitNotScalarExpr =
-      scalarFunctionExprToProto("bit_not", childProto)
+      scalarFunctionExprToProto("bitwise_not", childProto)
     optExprWithInfo(bitNotScalarExpr, expr, expr.children: _*)
   }
 }