Skip to content

Commit b8c5275

Browse files
authored
build: reduce overhead of fuzz testing (apache#3257)
* build: reduce overhead of fuzz testing * make workflow names consistent * fix
1 parent aaf3da5 commit b8c5275

2 files changed

Lines changed: 10 additions & 17 deletions

File tree

.github/workflows/pr_build_linux.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,27 +169,27 @@ jobs:
169169
- name: "Spark 3.5.5, JDK 17, Scala 2.13"
170170
java_version: "17"
171171
maven_opts: "-Pspark-3.5 -Dspark.version=3.5.5 -Pscala-2.13"
172-
scan_impl: "native_comet"
172+
scan_impl: "auto"
173173

174174
- name: "Spark 3.5.6, JDK 17, Scala 2.13"
175175
java_version: "17"
176176
maven_opts: "-Pspark-3.5 -Dspark.version=3.5.6 -Pscala-2.13"
177177
scan_impl: "native_comet"
178178

179-
- name: "Spark 3.5, JDK 17, Scala 2.12 native_datafusion"
179+
- name: "Spark 3.5, JDK 17, Scala 2.12"
180180
java_version: "17"
181181
maven_opts: "-Pspark-3.5 -Pscala-2.12"
182182
scan_impl: "native_datafusion"
183183

184-
- name: "Spark 3.5, JDK 17, Scala 2.12 native_iceberg_compat"
184+
- name: "Spark 3.5, JDK 17, Scala 2.12"
185185
java_version: "17"
186186
maven_opts: "-Pspark-3.5 -Pscala-2.12"
187187
scan_impl: "native_iceberg_compat"
188188

189189
- name: "Spark 4.0, JDK 17"
190190
java_version: "17"
191191
maven_opts: "-Pspark-4.0"
192-
scan_impl: "native_comet"
192+
scan_impl: "auto"
193193
suite:
194194
- name: "fuzz"
195195
value: |
@@ -267,7 +267,7 @@ jobs:
267267
value: |
268268
org.apache.spark.sql.CometToPrettyStringSuite
269269
fail-fast: false
270-
name: ${{ matrix.os }}/${{ matrix.profile.name }} [${{ matrix.suite.name }}]
270+
name: ${{ matrix.os }}/${{ matrix.profile.name }}/${{ matrix.profile.scan_impl }} [${{ matrix.suite.name }}]
271271
runs-on: ${{ matrix.os }}
272272
container:
273273
image: amd64/rust

spark/src/test/scala/org/apache/comet/CometFuzzTestBase.scala

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -112,18 +112,11 @@ class CometFuzzTestBase extends CometTestBase with AdaptiveSparkPlanHelper {
112112
override protected def test(testName: String, testTags: Tag*)(testFun: => Any)(implicit
113113
pos: Position): Unit = {
114114
Seq("native", "jvm").foreach { shuffleMode =>
115-
Seq(
116-
CometConf.SCAN_AUTO,
117-
CometConf.SCAN_NATIVE_COMET,
118-
CometConf.SCAN_NATIVE_DATAFUSION,
119-
CometConf.SCAN_NATIVE_ICEBERG_COMPAT).foreach { scanImpl =>
120-
super.test(testName + s" ($scanImpl, $shuffleMode shuffle)", testTags: _*) {
121-
withSQLConf(
122-
CometConf.COMET_NATIVE_SCAN_IMPL.key -> scanImpl,
123-
CometConf.COMET_PARQUET_UNSIGNED_SMALL_INT_CHECK.key -> "false",
124-
CometConf.COMET_SHUFFLE_MODE.key -> shuffleMode) {
125-
testFun
126-
}
115+
super.test(testName + s" ($shuffleMode shuffle)", testTags: _*) {
116+
withSQLConf(
117+
CometConf.COMET_PARQUET_UNSIGNED_SMALL_INT_CHECK.key -> "false",
118+
CometConf.COMET_SHUFFLE_MODE.key -> shuffleMode) {
119+
testFun
127120
}
128121
}
129122
}

0 commit comments

Comments
 (0)