remove_boxing_smaller_int_types

Author: B Vadlamani

datafusion/functions-aggregate-common/src/aggregate/count_distinct/native.rs

@@ -170,13 +170,13 @@ impl<T: ArrowPrimitiveType + Debug> Accumulator for FloatDistinctCountAccumulato
 /// Uses 256 bytes to track all possible u8 values.
 #[derive(Debug)]
 pub struct BoolArray256DistinctCountAccumulator {
-    seen: Box<[bool; 256]>,
+    seen: [bool; 256],
 }
 
 impl BoolArray256DistinctCountAccumulator {
     pub fn new() -> Self {
         Self {
-            seen: Box::new([false; 256]),
+            seen: [false; 256],
         }
     }
 
@@ -251,13 +251,13 @@ impl Accumulator for BoolArray256DistinctCountAccumulator {
 /// Uses 256 bytes to track all possible i8 values (mapped to 0..255).
 #[derive(Debug)]
 pub struct BoolArray256DistinctCountAccumulatorI8 {
-    seen: Box<[bool; 256]>,
+    seen: [bool; 256],
 }
 
 impl BoolArray256DistinctCountAccumulatorI8 {
     pub fn new() -> Self {
         Self {
-            seen: Box::new([false; 256]),
+            seen: [false; 256],
         }
     }
 

datafusion/functions-aggregate/src/count.rs

@@ -174,12 +174,12 @@ impl Count {
 }
 fn get_count_accumulator(data_type: &DataType) -> Box<dyn Accumulator> {
     match data_type {
-        // Use optimized bitmap/bool array accumulators for small integer types
+        // Optimized bitmap/bool array accumulators for small integer types
         DataType::UInt8 => Box::new(BoolArray256DistinctCountAccumulator::new()),
         DataType::Int8 => Box::new(BoolArray256DistinctCountAccumulatorI8::new()),
         DataType::UInt16 => Box::new(Bitmap65536DistinctCountAccumulator::new()),
         DataType::Int16 => Box::new(Bitmap65536DistinctCountAccumulatorI16::new()),
-        // Use HashSet-based accumulator for larger integer types
+        // HashSet-based accumulator for larger integer types
         DataType::Int32 => Box::new(PrimitiveDistinctCountAccumulator::<Int32Type>::new(
             data_type,
         )),