add apex support & remove nanoS support

tdejoigny-ledger · tdejoigny-ledger · commit 459e5428b161 · 2025-09-26T20:47:06.000+02:00
diff --git a/.github/workflows/codeql_checks.yml b/.github/workflows/codeql_checks.yml
@@ -15,31 +15,6 @@ on:
 
 jobs:
   analyse:
-    name: Analyse
-    strategy:
-      fail-fast: false
-      matrix:
-        sdk: ["$NANOX_SDK", "$NANOSP_SDK", "$STAX_SDK", "$FLEX_SDK"]
-        # 'cpp' covers C and C++
-        language: ['cpp']
-    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
-
-    steps:
-      - name: Clone
-        uses: actions/checkout@v4
-
-      - name: Initialize CodeQL
-        uses: github/codeql-action/init@v3
-        with:
-          languages: ${{ matrix.language }}
-          queries: security-and-quality
-
-      # CodeQL will create the database during the compilation
-      - name: Build
-        run: |
-          make BOLOS_SDK=${{ matrix.sdk }}
-
-      - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v3
+    name: Call Ledger CodeQL analysis
+    uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_codeql_checks.yml@v1
+    secrets: inherit
diff --git a/Makefile b/Makefile
@@ -29,20 +29,14 @@ APPNAME = "Kaspa"
 
 # Application version
 APPVERSION_M = 1
-APPVERSION_N = 1
+APPVERSION_N = 2
 APPVERSION_P = 0
 APPVERSION = "$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)"
 
-ifeq ($(TARGET_NAME),TARGET_NANOS)
-    DEFINES += MAX_INPUT_COUNT=15
-    DEFINES += MAX_MESSAGE_LEN=120
-else ifeq ($(TARGET_NAME),TARGET_STAX)
-    DEFINES += MAX_INPUT_COUNT=128
-    DEFINES += MAX_MESSAGE_LEN=200
-else
-    DEFINES += MAX_INPUT_COUNT=128
-    DEFINES += MAX_MESSAGE_LEN=200
-endif
+
+DEFINES += MAX_INPUT_COUNT=128
+DEFINES += MAX_MESSAGE_LEN=200
+
 
 # Application source files
 APP_SOURCE_PATH += src
@@ -54,6 +48,7 @@ ICON_NANOX = icons/nanox_kaspa_logo.gif
 ICON_NANOSP = icons/nanox_kaspa_logo.gif
 ICON_STAX = icons/stax_kaspa_logo_32px.gif
 ICON_FLEX = icons/stax_kaspa_logo_40px.gif
+ICON_APEX_P = icons/apex_kaspa_logo_32px.png
 
 # Application allowed derivation curves.
 # Possibles curves are: secp256k1, secp256r1, ed25519 and bls12381g1
diff --git a/glyphs/apex_app_kaspa_48px.png b/glyphs/apex_app_kaspa_48px.png
diff --git a/icons/apex_kaspa_logo_32px.png b/icons/apex_kaspa_logo_32px.png
diff --git a/ledger_app.toml b/ledger_app.toml
@@ -1,7 +1,7 @@
 [app]
 build_directory = "./"
 sdk = "C"
-devices = ["flex", "nanox", "nanos+", "stax"]
+devices = ["flex", "nanox", "nanos+", "stax", "apex_p"]
 
 [tests]
 unit_directory = "./unit-tests/"
diff --git a/src/ui/menu.h b/src/ui/menu.h
@@ -32,3 +32,9 @@ void ui_menu_main(void);
  * Show about submenu (copyright, date).
  */
 void ui_menu_about(void);
+
+#if defined(TARGET_STAX) || defined(TARGET_FLEX)
+#define ICON_APP_HOME C_stax_app_kaspa_64px
+#elif defined(TARGET_APEX_P)
+#define ICON_APP_HOME C_apex_app_kaspa_48px
+#endif
diff --git a/src/ui/menu_nbgl.c b/src/ui/menu_nbgl.c
@@ -54,7 +54,7 @@ static const nbgl_contentInfoList_t infoList = {
 
 void ui_menu_main(void) {
     nbgl_useCaseHomeAndSettings(APPNAME,
-                                &C_stax_app_kaspa_64px,
+                                &ICON_APP_HOME,
                                 NULL,
                                 INIT_HOME_PAGE,
                                 NULL,
diff --git a/src/ui/nbgl_display_address.c b/src/ui/nbgl_display_address.c
@@ -89,7 +89,7 @@ int ui_display_address() {
 
     nbgl_useCaseAddressReview(g_address,
                               &pairList,
-                              &C_stax_app_kaspa_64px,
+                              &ICON_APP_HOME,
                               "Verify KAS address",
                               NULL,
                               review_choice);
diff --git a/src/ui/nbgl_display_message.c b/src/ui/nbgl_display_message.c
@@ -94,7 +94,7 @@ int ui_display_message() {
     // Start review flow
     nbgl_useCaseReview(TYPE_MESSAGE,
                        &pairList,
-                       &C_stax_app_kaspa_64px,
+                       &ICON_APP_HOME,
                        "Review message",
                        NULL,
                        "Sign message?",
diff --git a/src/ui/nbgl_display_transaction.c b/src/ui/nbgl_display_transaction.c
@@ -127,7 +127,7 @@ int ui_display_transaction() {
     // Start review flow
     nbgl_useCaseReview(TYPE_TRANSACTION,
                        &pairList,
-                       &C_stax_app_kaspa_64px,
+                       &ICON_APP_HOME,
                        "Review transaction\nto send KAS",
                        NULL,
                        "Sign transaction\nto send KAS",
diff --git a/tests/test_name_version.py b/tests/test_name_version.py
@@ -12,4 +12,4 @@ def test_get_app_and_version(backend, backend_name):
     app_name, version = unpack_get_app_and_version_response(response.data)
 
     assert app_name == "Kaspa"
-    assert version == "1.1.0"
+    assert version == "1.2.0"
diff --git a/tests/test_version_cmd.py b/tests/test_version_cmd.py
@@ -3,7 +3,7 @@
 
 # Taken from the Makefile, to update every time the Makefile version is bumped
 MAJOR = 1
-MINOR = 1
+MINOR = 2
 PATCH = 0
 
 # In this test we check the behavior of the device when asked to provide the app version
diff --git a/tests/usage.md b/tests/usage.md
@@ -20,7 +20,7 @@ You can use for this the container `ghcr.io/ledgerhq/ledger-app-builder/ledger-a
 docker pull ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
 cd <your app repository>                        # replace <appname> with the name of your app, (eg boilerplate)
 docker run --user "$(id -u)":"$(id -g)" --rm -ti -v "$(realpath .):/app" --privileged -v "/dev/bus/usb:/dev/bus/usb" ledger-app-builder-lite:latest
-make clean && make BOLOS_SDK=$<device>_SDK      # replace <device> with one of [NANOS, NANOX, NANOSP, STAX]
+make clean && make BOLOS_SDK=$<device>_SDK      # replace <device> with one of [NANOS, NANOX, NANOSP, STAX, FLEX, APEX_P]
 exit
 ```
 
@@ -41,7 +41,7 @@ You can use for this the container `ghcr.io/ledgerhq/ledger-app-builder/ledger-a
 docker pull ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest
 cd app-<appname>/                                   # replace <appname> with the name of your app, (eg boilerplate)
 docker run --user "$(id -u)":"$(id -g)" --rm -ti -v "$(realpath .):/app" --privileged -v "/dev/bus/usb:/dev/bus/usb" ledger-app-builder-lite:latest
-make clean && make BOLOS_SDK=$<device>_SDK load     # replace <device> with one of [NANOS, NANOX, NANOSP, STAX]
+make clean && make BOLOS_SDK=$<device>_SDK load     # replace <device> with one of [NANOS, NANOX, NANOSP, STAX, FLEX, APEX_P]
 exit
 ```
 
@@ -65,7 +65,7 @@ Standard useful pytest options
 
 Custom pytest options
 ```
-    --device <device>           run the test on the specified device [nanos,nanox,nanosp,stax,all]. This parameter is mandatory
+    --device <device>           run the test on the specified device [nanos,nanox,nanosp,stax,flex,apex_p,all]. This parameter is mandatory
     --backend <backend>         run the tests against the backend [speculos, ledgercomm, ledgerwallet]. Speculos is the default
     --display                   on Speculos, enables the display of the app screen using QT
     --golden_run                on Speculos, screen comparison functions will save the current screen instead of comparing
