Skip to content

Issue 2 create landing page - #35

Merged
allyharrison merged 23 commits into
mainfrom
issue-2-Create_landing_page
Jul 19, 2025
Merged

Issue 2 create landing page#35
allyharrison merged 23 commits into
mainfrom
issue-2-Create_landing_page

Conversation

@Shinetopia

@Shinetopia Shinetopia commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Change Summary

Contains the landing page following the design & layout from the client's example page.

Possible changes required before merging

  • countdown to next competition may need to be removed
  • 'learn more about the event' just links back to the rules page at the moment, for the 'download rules manual' are we allowed to supply the website with the manual we've been given?

Other information

  • the previous flex declarations in _app.tsx for main did not work with the existing landing page's content so it was removed, other pages may not be formatted correctly until all pages are merged in for refactoring

Related issue

KatG33 and others added 16 commits July 6, 2025 09:07
cloned Docker container access
* Added Figma text styles for css & tailwind use

* Added Figma colour palette

* changed style jsx to inline variable declaration

* hotfix: added missing font variable

* quick hotfix: worksans variable not set properly

---------

Co-authored-by: Jayshira <jason.yulfan@gmail.com>
* Added Figma text styles for css & tailwind use

* Added Figma colour palette

* changed style jsx to inline variable declaration

* hotfix: added missing font variable

* quick hotfix: worksans variable not set properly

---------

Co-authored-by: Jayshira <jason.yulfan@gmail.com>
@Shinetopia
Shinetopia requested a review from samueltl21 July 17, 2025 08:35
@Shinetopia
Shinetopia removed the request for review from samueltl21 July 19, 2025 03:53
allyharrison
allyharrison previously approved these changes Jul 19, 2025
@Shinetopia
Shinetopia requested review from allyharrison and removed request for allyharrison July 19, 2025 04:31
Comment thread client/src/pages/_app.tsx Outdated
Comment thread client/src/pages/index.tsx Outdated
Comment thread client/src/components/ui/navbar.tsx Outdated

@JeremiahPinto JeremiahPinto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Some minor changes to be made to make the code easier to read but not a big issue. The recommendation I would make is changing the styles declared in global.css

Comment thread client/src/styles/globals.css
Removed max-w for the main section as well as the checklist
Centered the "equipment ready" text at the checklist too
Removed the extra Navbar, as well as adding some basic responsiveness
allyharrison
allyharrison previously approved these changes Jul 19, 2025
Add resizable container as well as the ProgressBar component to the schedule page
Changed various padding, and responsiveness for mobile for the EventCard, as well as changing the title inside the ProgressBar
@allyharrison
allyharrison merged commit dfafa6f into main Jul 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create landing page

5 participants