updates

ErikaKK · ErikaKK · commit 72584f2cdae1 · 2026-04-09T21:48:57.000+08:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,6 +7,9 @@ on:
     types: ["opened", "synchronize", "reopened", "edited"]
   workflow_dispatch:
 
+  permissions:
+  contents: read
+
 jobs:
   format:
     name: Run Prettier
diff --git a/src/app/api/cron/cycle-memberships/route.ts b/src/app/api/cron/cycle-memberships/route.ts
@@ -1,6 +1,6 @@
 import * as Sentry from "@sentry/nextjs"
 import { format } from "date-fns"
-import { and, eq, lte } from "drizzle-orm"
+import { lte } from "drizzle-orm"
 import type { NextRequest } from "next/server"
 import { Resend } from "resend"
 
@@ -22,14 +22,12 @@ export async function GET(request: NextRequest) {
   }
 
   let dbRes: (typeof User.$inferSelect)[] = []
-  const now = new Date()
-  const today = new Date(now)
+  const today = new Date()
 
   await Sentry.withMonitor("cycle-memberships", async () => {
-    // TODO: backup db and put into aws bucket
     dbRes = await db
       .update(User)
-      .set({ role: null, membership_expiry: null, reminder_pending: true })
+      .set({ role: null, membership_expiry: null })
       .where(lte(User.membership_expiry, today))
       .returning()
   })
diff --git a/src/app/api/cron/prevent-supabase-pausing/route.ts b/src/app/api/cron/prevent-supabase-pausing/route.ts
@@ -14,12 +14,12 @@ export async function GET(request: NextRequest) {
     })
   }
 
-  let dbHealth
+  let dbHealth = false
   try {
     const result = await db.execute<{ healthy: boolean }>(sql`SELECT true as healthy`)
-    dbHealth = result.rows[0]?.healthy
+    dbHealth = result.rows[0]?.healthy ?? false
   } catch (err) {
-    dbHealth = false
+    console.error("Database health check failed", err)
   }
 
   return Response.json(
diff --git a/src/components/email-template.tsx b/src/components/email-template.tsx
@@ -2,8 +2,8 @@ import { Body, Button, Container, Head, Html, Img, Preview, Section, Text } from
 import * as React from "react"
 
 interface MembershipRenewalReminderEmailProps {
-  firstname?: string
-  membershipEndDate?: string
+  firstname: string
+  membershipEndDate: string
   websiteLink?: string
 }
 
@@ -12,12 +12,6 @@ export const MembershipRenewalReminderEmail = ({
   membershipEndDate,
   websiteLink = "https://codersforcauses.org/join",
 }: MembershipRenewalReminderEmailProps) => {
-  // let year = new Date().getFullYear()
-  // const month = new Date().getMonth()
-  // if (month < 6) {
-  //   year -= 1
-  // }
-
   return (
     <Html>
       <Head />

Original file line number	Diff line number	Diff line change
`@@ -14,12 +14,12 @@ export async function GET(request: NextRequest) {`
`14`	`14`	`})`
`15`	`15`	`}`
`16`	`16`
`17`		`- let dbHealth`
	`17`	`+ let dbHealth = false`
`18`	`18`	`try {`
`19`	`19`	const result = await db.execute<{ healthy: boolean }>(sql`SELECT true as healthy`)
`20`		`- dbHealth = result.rows[0]?.healthy`
	`20`	`+ dbHealth = result.rows[0]?.healthy ?? false`
`21`	`21`	`} catch (err) {`
`22`		`- dbHealth = false`
	`22`	`+ console.error("Database health check failed", err)`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`return Response.json(`