Skip to content

Commit 525161a

Browse files
committed
chore(skills): resync plan-dag — pick up test.sh --stagger=0 fix
Pulls in onsager-ai/onsager-skills@d178bc0 which makes the `--stagger=0` smoke check actually fail loudly instead of swallowing the exit code with `|| true`.
1 parent dbb9d2b commit 525161a

2 files changed

Lines changed: 22 additions & 8 deletions

File tree

.agents/skills/plan-dag/scripts/plan-dag-render.test.sh

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -359,14 +359,28 @@ PY
359359
printf ' FAIL --stagger did not measurably shrink width (%s → %s pt)\n' "$raw_w" "$stag_w"
360360
fi
361361
fi
362-
# --stagger=0 must always produce identical output to the no-unflatten baseline.
362+
# --stagger=0 must produce a valid PNG (same shape as the happy-path PNG smoke
363+
# above): capture the exit code, treat a Playwright-skip stderr as skip, and
364+
# fail loudly for anything else.
363365
"$SCRIPT" "$FIX/happy.json" --stagger=0 --out "$tmp/stag0.png" \
364-
>/dev/null 2>"$tmp/stag0.err" || true
365-
if grep -qE "$png_skip_re" "$tmp/stag0.err" 2>/dev/null; then
366-
printf ' skip --stagger=0 PNG (Playwright/Chromium not available)\n'
367-
elif [ ! -s "$tmp/stag0.png" ] && [ ! -e "$tmp/stag0.png" ]; then
368-
: # nothing to assert
369-
elif file "$tmp/stag0.png" 2>/dev/null | grep -q 'PNG image'; then
366+
>/dev/null 2>"$tmp/stag0.err"
367+
rc=$?
368+
if [ "$rc" -ne 0 ]; then
369+
if grep -qE "$png_skip_re" "$tmp/stag0.err"; then
370+
printf ' skip --stagger=0 PNG (Playwright/Chromium not available)\n'
371+
else
372+
fail=$((fail + 1))
373+
printf ' FAIL --stagger=0 exited %d\n' "$rc"
374+
sed 's/^/ /' < "$tmp/stag0.err"
375+
fi
376+
elif [ ! -s "$tmp/stag0.png" ]; then
377+
fail=$((fail + 1))
378+
printf ' FAIL --stagger=0 produced empty output\n'
379+
elif ! file "$tmp/stag0.png" 2>/dev/null | grep -q 'PNG image'; then
380+
fail=$((fail + 1))
381+
printf ' FAIL --stagger=0 output is not a PNG (file: %s)\n' \
382+
"$(file "$tmp/stag0.png" 2>/dev/null || echo unknown)"
383+
else
370384
pass=$((pass + 1))
371385
printf ' ok --stagger=0 renders a PNG\n'
372386
fi

skills-lock.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"source": "onsager-ai/onsager-skills",
1616
"sourceType": "github",
1717
"skillPath": "skills/plan-dag/SKILL.md",
18-
"computedHash": "832e649a4efa93b178636a5e11b0cf1fc4441931ab82493baeb87540448e63cc"
18+
"computedHash": "203486861e5e1576084b2ec9b73a3b67b8b22d2904516d59477a65c548cf1db5"
1919
}
2020
}
2121
}

0 commit comments

Comments
 (0)