chore(skills): sync plan-dag from onsager-skills (PNG-only renderer)#293
Conversation
Pulls the latest plan-dag (upstream commits #9–#13): renderer collapsed to PNG-only, status fills + available-next highlight, duplicate-id labels rejected, and the obsolete ascii/tb/svg/html fixture artifacts dropped. Moves the skill from .claude/skills/plan-dag/ (real directory) to .agents/skills/plan-dag/ with a .claude/skills/plan-dag symlink, matching the multi-agent layout the skills CLI now emits.
There was a problem hiding this comment.
Pull request overview
Syncs the upstream plan-dag skill from onsager-ai/onsager-skills into this repo, including the updated renderer/tooling and updated skills-lock.json hash. The updated skill drops non-PNG render targets and shifts the on-disk layout to the newer multi-agent .agents/ structure (with .claude/ compatibility preserved via the repo’s install layout).
Changes:
- Bump
skills-lock.jsonto the new upstreamplan-dagcontent hash. - Update
plan-dagrenderer + tests to a PNG-only pipeline (Graphviz SVG → Playwright/Chromium screenshot). - Move
plan-dagskill content under.agents/skills/plan-dag/(and remove legacy.upstream-sourcemarker from the prior layout).
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| skills-lock.json | Updates the recorded content hash for the vendored plan-dag skill. |
| .agents/skills/plan-dag/SKILL.md | Updates skill docs/instructions to reflect PNG-only rendering and updated workflow. |
| .agents/skills/plan-dag/scripts/plan-dag-render.py | Replaces the multi-target renderer with a PNG-only renderer + updated validation rules. |
| .agents/skills/plan-dag/scripts/svg-to-png.mjs | Adds the Playwright-based SVG→PNG rasterization helper. |
| .agents/skills/plan-dag/scripts/plan-dag-render.test.sh | Updates tests to cover PNG pipeline + validator behavior (with PNG smoke skip logic). |
| .agents/skills/plan-dag/fixtures/happy.json | New fixture for end-to-end PNG + styled DOT checks. |
| .agents/skills/plan-dag/fixtures/bad.json | New fixture for validator failure cases (incl. duplicate “own id” in label). |
| .agents/skills/plan-dag/fixtures/cycle.json | New fixture for cycle-detection validation coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| args = ap.parse_args() | ||
|
|
||
| text = sys.stdin.read() if args.ir == "-" else Path(args.ir).read_text() |
There was a problem hiding this comment.
Valid suggestion, but .agents/skills/plan-dag/scripts/plan-dag-render.py is upstream-owned by onsager-ai/onsager-skills and re-synced into this repo via npx skills add / npx skills update. Editing the downstream copy would be silently overwritten by the next sync. The right fix lives upstream — happy to open an issue/PR over there.
Generated by Claude Code
Summary
Mirrors upstream onsager-ai/onsager-skills
plan-daginto this repo's installed copy vianpx skills update -y. Pulls PRs #9–#13:--as=ascii/--as=tb/--as=svg/--as=htmltargets dropped (HTML didn't render inline in chat; ASCII lost column alignment and couldn't carry status fills).Also migrates the on-disk layout from
.claude/skills/plan-dag/(real directory +.upstream-sourcemarker) to.agents/skills/plan-dag/with a.claude/skills/plan-dagsymlink — the multi-agent layout the skills CLI now emits.Test plan
diff -rq /home/user/onsager-skills/skills/plan-dag /home/user/lean-spec/.agents/skills/plan-dagclean.skills-lock.jsoncomputedHashfor plan-dag bumped to upstream HEAD (7757819).npx skills listshows plan-dag installed under./.claude/skills/plan-dag.Content-only sync of an upstream-owned skill.
https://claude.ai/code/session_013cXjX7dK2UypgF8iC3z6VB
Generated by Claude Code