fix: Decouple pitcher-client (#148)

Author: christianalfoni

build/plugins.cjs

@@ -12,27 +12,3 @@ module.exports.moduleReplacementPlugin = function moduleReplacementPlugin(
     },
   };
 };
-
-module.exports.forbidImportsPlugin = function forbidImportsPlugin(imports) {
-  return {
-    name: "forbid-imports",
-    setup(build) {
-      for (const packageName of imports) {
-        // catch `import ... from 'packageName'` **and** sub-paths `packageName/foo`
-        const pkgFilter = new RegExp(`^${packageName}($|/)`);
-        build.onResolve({ filter: pkgFilter }, (args) => {
-          return {
-            errors: [
-              {
-                text: `❌ Importing “${packageName}” is forbidden in this project.`,
-                notes: [
-                  "If you really need it, talk to your team lead about an exception.",
-                ],
-              },
-            ],
-          };
-        });
-      }
-    },
-  };
-};

esbuild.cjs

@@ -1,17 +1,7 @@
 const { join } = require("path");
 const esbuild = require("esbuild");
 const { externalModules, define } = require("./build/utils.cjs");
-const {
-  moduleReplacementPlugin,
-  forbidImportsPlugin,
-} = require("./build/plugins.cjs");
-
-// Until pitcher-client is part of SDK we need to forbid these imports in
-// Node builds
-const preventPitcherClientImportsPlugin = forbidImportsPlugin([
-  "@codesandbox/pitcher-protocol",
-  "@codesandbox/pitcher-common",
-]);
+const { moduleReplacementPlugin } = require("./build/plugins.cjs");
 
 const devtoolsStubPlugin = {
   name: "stub-react-devtools",
@@ -86,7 +76,6 @@ const nodeClientCjsBuild = esbuild.build({
   outfile: "dist/cjs/node.cjs",
   platform: "node",
   external: externalModules,
-  plugins: [preventPitcherClientImportsPlugin],
 });
 
 const nodeClientEsmBuild = esbuild.build({
@@ -96,7 +85,6 @@ const nodeClientEsmBuild = esbuild.build({
   outfile: "dist/esm/node.js",
   platform: "node",
   external: externalModules,
-  plugins: [preventPitcherClientImportsPlugin],
 });
 
 /**
@@ -121,7 +109,6 @@ const sdkEsmBuild = esbuild.build({
   platform: "node",
   outfile: "dist/esm/index.js",
   external: externalModules,
-  plugins: [preventPitcherClientImportsPlugin],
 });
 
 /**
@@ -147,7 +134,7 @@ const cliBuild = esbuild.build({
     ),
     "@codesandbox/sdk",
   ],
-  plugins: [preventPitcherClientImportsPlugin, devtoolsStubPlugin],
+  plugins: [devtoolsStubPlugin],
 });
 
 Promise.all([