Skip to content

Commit fa5d033

Browse files
committed
update devcontainer base images to newer versions
1 parent 76946ac commit fa5d033

5 files changed

Lines changed: 25 additions & 5 deletions

File tree

.github/workflows/build.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,13 @@ jobs:
1515

1616
strategy:
1717
matrix:
18-
image: ["typescript-node", "universal"]
18+
include:
19+
- image: "typescript-node"
20+
tag: "22"
21+
- image: "typescript-node"
22+
tag: "24"
23+
- image: "universal"
24+
tag: "4.1.0-noble"
1925

2026
steps:
2127
- name: Checkout
@@ -33,6 +39,8 @@ jobs:
3339
with:
3440
subFolder: ${{ matrix.image }}
3541
imageName: ghcr.io/codesandbox/devcontainers/${{ matrix.image }}
36-
imageTag: latest,0.5
42+
imageTag: ${{ matrix.tag }}
3743
cacheFrom: ghcr.io/codesandbox/devcontainers/${{ matrix.image }}
3844
push: always
45+
env:
46+
TAG: ${{ matrix.tag }}
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
ARG TAG=24
2+
FROM mcr.microsoft.com/devcontainers/typescript-node:${TAG}

typescript-node/.devcontainer/devcontainer.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
{
22
"name": "CodeSandbox Typescript Node.js",
3-
"image": "mcr.microsoft.com/devcontainers/typescript-node:20",
3+
"build": {
4+
"context": ".",
5+
"dockerfile": "Dockerfile",
6+
"args": {
7+
"TAG": "${localEnv:TAG}"
8+
}
9+
},
410
"features": {
511
"ghcr.io/codesandbox/devcontainer-features/codesandbox:0.1.4": {}
612
},

universal/.devcontainer/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
FROM mcr.microsoft.com/devcontainers/universal:2-focal
1+
ARG TAG=4.1.0-noble
2+
FROM mcr.microsoft.com/devcontainers/universal:${TAG}
23

34
USER root
45

universal/.devcontainer/devcontainer.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22
"name": "CodeSandbox Universal",
33
"build": {
44
"context": ".",
5-
"dockerfile": "Dockerfile"
5+
"dockerfile": "Dockerfile",
6+
"args": {
7+
"TAG": "${localEnv:TAG}"
8+
}
69
},
710
"features": {
811
"ghcr.io/codesandbox/devcontainer-features/codesandbox:0.1.4": {}

0 commit comments

Comments
 (0)