Fixing issues 231 (token visible) and 232 (oauth secret and zip file paths)#233
Open
abesnier wants to merge 4 commits intocodeskyblue:masterfrom
Open
Fixing issues 231 (token visible) and 232 (oauth secret and zip file paths)#233abesnier wants to merge 4 commits intocodeskyblue:masterfrom
abesnier wants to merge 4 commits intocodeskyblue:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Hardening
Summary
This PR addresses three security concerns in gohttpserver: preventing Zip Slip directory traversal attacks, securing session management, and removing sensitive auth info from API responses.
Changes
Zip Slip protection in
unzipFile(zip.go)Secure session secret management (openid-login.go)
"something-very-secret"session secret with a configurableGHS_SESSION_SECRETenvironment variable.Remove auth info from JSON response (httpstaticserver.go)
authfield from the?json=trueAPI response to prevent .ghs.yml configuration details (including access control rules) from being exposed to unauthenticated users.Files Changed
authfield in JSON response