Skip to content

chore(argocd) remove unused projects#512

Open
Jcing95 wants to merge 2 commits into
mainfrom
argocd-remove-projects
Open

chore(argocd) remove unused projects#512
Jcing95 wants to merge 2 commits into
mainfrom
argocd-remove-projects

Conversation

@Jcing95

@Jcing95 Jcing95 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the Codesphere-managed ArgoCD AppProject resources (prod and dev) that were applied during oms beta install argocd --deploy-dc-config. These projects are no longer needed.

Changes

  • Drop AppProjects from the install flowApplyAll no longer calls applyAppProjects; the method and its embedded appProjectsYAML are removed (internal/installer/argocd/argocd_resources.go).
  • Delete the manifestinternal/installer/argocd/manifests/app-projects.yaml.
  • Remove the now-dead dynClient dependencyargoCDResources only used the dynamic client to apply AppProjects, so it's dropped from the struct, the NewArgoCDResources signature, and both wiring sites in installer.go.
  • Remove the dead AppProject GVR mapping and its test case (internal/util/k8s.go, internal/util/k8s_test.go) — nothing produces an AppProject object anymore.
  • Update help text — removed the AppProjects (always) line and the AppProjects mention from the --deploy-dc-config flag description (cli/cmd/argocd.go).

Notes

--deploy-dc-config still applies the Helm OCI registry secret, the local cluster secret (with --dc-id), and git repo credentials.

🤖 Generated with Claude Code

@Jcing95 Jcing95 requested a review from schrodit June 19, 2026 08:17
@Jcing95 Jcing95 self-assigned this Jun 19, 2026
@Jcing95 Jcing95 removed the request for review from schrodit June 19, 2026 08:21
@Jcing95 Jcing95 force-pushed the argocd-remove-projects branch from 1593b0c to 57c7ebf Compare June 19, 2026 08:32
@Jcing95 Jcing95 requested a review from schrodit June 19, 2026 08:33
Signed-off-by: Jcing95 <23337729+Jcing95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants