Merge pull request #23 from codesyntax/improve-add

fix: do not let adding existing items to the registry through the uti…

Author: erral

news/+addview.bugfix

@@ -0,0 +1 @@
+Return false if trying to add a view that exists to the registry @erral

src/cs_dynamicpages/testing.py

@@ -17,6 +17,7 @@ def setUpZope(self, app, configurationContext):
         # The z3c.autoinclude feature is disabled in the Plone fixture base
         # layer.
         self.loadZCML(package=cs_dynamicpages)
+        self.loadZCML(package=cs_dynamicpages, name="testing.zcml")
 
     def setUpPloneSite(self, portal):
         applyProfile(portal, "cs_dynamicpages:default")

src/cs_dynamicpages/testing.zcml

@@ -0,0 +1,23 @@
+<configure
+    xmlns="http://namespaces.zope.org/zope"
+    xmlns:browser="http://namespaces.zope.org/browser"
+    xmlns:plone="http://namespaces.plone.org/plone"
+    i18n_domain="cs_dynamicpages"
+    >
+
+  <!-- Register a dummy view to be able to use it in tests -->
+
+  <configure package=".views">
+
+    <browser:page
+        name="cs_dynamicpages-some-custom-view"
+        for="cs_dynamicpages.content.dynamic_page_row.IDynamicPageRow"
+        class=".slider_view.SliderView"
+        template="slider_view.pt"
+        permission="zope2.View"
+        layer="cs_dynamicpages.interfaces.IBrowserLayer"
+        />
+  </configure>
+
+
+</configure>

src/cs_dynamicpages/tests/test_utils.py

@@ -11,6 +11,7 @@
 from plone import api
 from plone.app.testing import setRoles
 from plone.app.testing import TEST_USER_ID
+from zope.schema.interfaces import WrongContainedType
 
 import unittest
 
@@ -143,7 +144,7 @@ def test_add_custom_view_returns_true(self):
         if existing_views:
             # Test with existing view - function should still work
             result = add_custom_view(
-                existing_views[0]["row_type"],
+                "cs_dynamicpages-some-custom-view",
                 ["title", "description"],
                 has_button=False,
                 icon="star",
@@ -153,10 +154,26 @@ def test_add_custom_view_returns_true(self):
         else:
             self.skipTest("No existing views to test with")
 
+    def test_add_custom_view_returns_false(self):
+        # Use an existing view name
+        existing_views = get_available_views_for_row()
+        if existing_views:
+            # Test with existing view - function should still work
+            result = add_custom_view(
+                existing_views[0]["row_type"],
+                ["title", "description"],
+                has_button=False,
+                icon="star",
+            )
+            # Function returns True even if view already exists
+            self.assertFalse(result)
+        else:
+            self.skipTest("No existing views to test with")
+
     def test_add_custom_view_structure(self):
         """Test that add_custom_view creates correct structure."""
         # Test using slider-view which is registered
-        view_name = "cs_dynamicpages-slider-view"
+        view_name = "cs_dynamicpages-some-custom-view"
         original_len = len(api.portal.get_registry_record(self.record_name))
 
         add_custom_view(view_name, ["title"], has_button=True, icon="heart")
@@ -175,7 +192,7 @@ def test_add_custom_view_structure(self):
 
     def test_add_custom_view_default_icon_is_bricks(self):
         """Test that default icon is 'bricks'."""
-        view_name = "cs_dynamicpages-featured-view"
+        view_name = "cs_dynamicpages-some-custom-view"
 
         add_custom_view(view_name, ["title"])
 
@@ -185,6 +202,13 @@ def test_add_custom_view_default_icon_is_bricks(self):
         last_match = matching[-1]  # Get the last added one
         self.assertEqual(last_match["row_type_icon"], "bricks")
 
+    def test_add_not_available_custom_view_fails(self):
+        """try to add a view that is not registered"""
+        view_name = "cs_dynamicpages-this-view-does-not-exist"
+
+        with self.assertRaises(WrongContainedType):
+            add_custom_view(view_name, ["title"])
+
 
 class EnableBehaviorIntegrationTest(unittest.TestCase):
     """Integration tests for enable_behavior function."""

src/cs_dynamicpages/utils.py

@@ -32,6 +32,10 @@ def add_custom_view(
     """utility function to add a given view to the list of available row types"""
     record_name = "cs_dynamicpages.dynamic_pages_control_panel.row_type_fields"
     values = api.portal.get_registry_record(record_name)
+    existing_views = [item.get("row_type") for item in values]
+    if view_name in existing_views:
+        return False
+
     new_item = {
         "row_type": view_name,
         "each_row_type_fields": shown_fields,