Skip to content

Commit 7ff9fb2

Browse files
committed
Improve assertion tests using local variables
1 parent 40223de commit 7ff9fb2

2 files changed

Lines changed: 14 additions & 8 deletions

File tree

tema1_2_ejem1/src/test/java/es/codeurjc/test/ejem/AppTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ public class AppTest {
99

1010
@Test
1111
public void testSuma() {
12-
assertEquals("Text", "Text");
12+
String text = "Text";
13+
assertEquals("Text", text);
1314
}
1415

1516
@Test

tema1_2_ejem2_assertj/src/test/java/es/codeurjc/test/ejem/AssertJTest.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,29 +12,34 @@ public class AssertJTest {
1212

1313
@Test
1414
public void testAssertTrue() {
15-
assertTrue("pepe".equals("juan"));
15+
String name = "pepe";
16+
assertTrue(name.equals("juan"));
1617
}
1718

1819
@Test
1920
public void testAssertEquals() {
20-
assertEquals("pepe","juan");
21+
String name = "pepe";
22+
assertEquals(name,"juan");
2123
}
2224

2325
@Test
2426
public void testAssertThatEquals() {
25-
//assertThat("pepe", equalTo("juan"));
26-
assertThat("pepe").isEqualTo("juan");
27+
String name = "pepe";
28+
//assertThat(name, equalTo("juan"));
29+
assertThat(name).isEqualTo("juan");
2730
}
2831

2932
@Test
3033
public void testAssertStartsWith() {
31-
assertTrue("pepe".startsWith("ju"));
34+
String name = "pepe";
35+
assertTrue(name.startsWith("ju"));
3236
}
3337

3438
@Test
3539
public void testAssertThatStartsWith() {
36-
//assertThat("pepe", startsWith("ju"));
37-
assertThat("pepe").startsWith("ju");
40+
String name = "pepe";
41+
//assertThat(name, startsWith("ju"));
42+
assertThat(name).startsWith("ju");
3843
}
3944

4045
@Test

0 commit comments

Comments
 (0)