Skip to content

Commit 8275ffe

Browse files
authored
Merge pull request #2223 from tf/teaser-link-preview-fix
Ensure teaser item link preview can be clicked
2 parents ccc11c8 + bd5157c commit 8275ffe

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

entry_types/scrolled/package/src/frontend/Figure.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ export function Figure({
6161
onChange={onCaptionChange}
6262
onlyParagraphs={true}
6363
hyphens="none"
64-
floatingControlsPosition="above"
6564
placeholder={t('pageflow_scrolled.inline_editing.type_text')} />
6665
</figcaption>}
6766
</figure>

entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export const EditableText = React.memo(function EditableText({
6060
value, contentElementId, placeholder, onChange, selectionRect, className,
6161
placeholderClassName, scaleCategory = 'body', typographyVariant, typographySize,
6262
autoFocus,
63-
floatingControlsPosition = 'below'
63+
floatingControlsPosition = 'above'
6464
}) {
6565
const editor = useMemo(
6666
() => withLinks(

entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ export function LinkPreview({href, openInNewTab, children, className}) {
7878
<span ref={ref}
7979
className={className}
8080
onMouseEnter={() => activate(href, openInNewTab, ref)}
81-
onMouseLeave={deactivate}
82-
onMouseDown={deactivate}>
81+
onMouseLeave={deactivate}>
8382
{children}
8483
</span>
8584
);
@@ -96,6 +95,7 @@ export function LinkTooltip({disabled, position, align, state}) {
9695
<div className={classNames(styles.linkTooltip,
9796
styles[`position-${position}`],
9897
styles[`align-${align}`])}
98+
onClick={e => e.stopPropagation()}
9999
onMouseEnter={keep}
100100
onMouseLeave={deactivate}
101101
style={{top: state.top, bottom: state.bottom, left: state.left}}>

0 commit comments

Comments
 (0)