From f97466f93269287275593787ad105a5ab53a523e Mon Sep 17 00:00:00 2001 From: Tim Fischbach Date: Thu, 10 Apr 2025 12:51:16 +0200 Subject: [PATCH 1/2] Ensure teaser item link preview can be clicked Stop propagation in link preview to prevent teaser list from preventing default. --- .../scrolled/package/src/frontend/inlineEditing/LinkTooltip.js | 1 + 1 file changed, 1 insertion(+) diff --git a/entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js b/entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js index d379d914b8..9a5f27c05a 100644 --- a/entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js +++ b/entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js @@ -96,6 +96,7 @@ export function LinkTooltip({disabled, position, align, state}) {
e.stopPropagation()} onMouseEnter={keep} onMouseLeave={deactivate} style={{top: state.top, bottom: state.bottom, left: state.left}}> From bd5157c3b5dcc6ac6e9665b69f4914c89ca26324 Mon Sep 17 00:00:00 2001 From: Tim Fischbach Date: Thu, 10 Apr 2025 12:53:04 +0200 Subject: [PATCH 2/2] Do not close link preview on click Instead prevent collision with hovering toolbar by displaying preview above. --- entry_types/scrolled/package/src/frontend/Figure.js | 1 - .../package/src/frontend/inlineEditing/EditableText/index.js | 2 +- .../scrolled/package/src/frontend/inlineEditing/LinkTooltip.js | 3 +-- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/entry_types/scrolled/package/src/frontend/Figure.js b/entry_types/scrolled/package/src/frontend/Figure.js index aaa30bebfc..ebade077f4 100644 --- a/entry_types/scrolled/package/src/frontend/Figure.js +++ b/entry_types/scrolled/package/src/frontend/Figure.js @@ -61,7 +61,6 @@ export function Figure({ onChange={onCaptionChange} onlyParagraphs={true} hyphens="none" - floatingControlsPosition="above" placeholder={t('pageflow_scrolled.inline_editing.type_text')} /> } diff --git a/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.js b/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.js index 3c00c7ca31..3979e9f286 100644 --- a/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.js +++ b/entry_types/scrolled/package/src/frontend/inlineEditing/EditableText/index.js @@ -60,7 +60,7 @@ export const EditableText = React.memo(function EditableText({ value, contentElementId, placeholder, onChange, selectionRect, className, placeholderClassName, scaleCategory = 'body', typographyVariant, typographySize, autoFocus, - floatingControlsPosition = 'below' + floatingControlsPosition = 'above' }) { const editor = useMemo( () => withLinks( diff --git a/entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js b/entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js index 9a5f27c05a..49240b1f9d 100644 --- a/entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js +++ b/entry_types/scrolled/package/src/frontend/inlineEditing/LinkTooltip.js @@ -78,8 +78,7 @@ export function LinkPreview({href, openInNewTab, children, className}) { activate(href, openInNewTab, ref)} - onMouseLeave={deactivate} - onMouseDown={deactivate}> + onMouseLeave={deactivate}> {children} );