Clear stale permalink redirect on slug change#2403
Merged
Conversation
Previously, updating a permalink's slug or directory could fail with a duplicate-key error on the permalink_redirects unique index. This happened when a prior holder of the same slug had left a redirect behind: if this permalink then took that slug while its entry was still unpublished, the redirect-creation callback was skipped and the old redirect lingered. Once the entry was published and its slug was changed again, inserting the new redirect collided with the zombie. Cleaning up any existing redirect for the old slug/directory before creating the new one ensures renaming published entries stays reliable, while unpublished slug changes still leave live redirects of other entries untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, updating a permalink's slug or directory could fail with a duplicate-key error on the permalink_redirects unique index. This happened when a prior holder of the same slug had left a redirect behind: if this permalink then took that slug while its entry was still unpublished, the redirect-creation callback was skipped and the old redirect lingered. Once the entry was published and its slug was changed again, inserting the new redirect collided with the zombie.
Cleaning up any existing redirect for the old slug/directory before creating the new one ensures renaming published entries stays reliable, while unpublished slug changes still leave live redirects of other entries untouched.