Merge pull request #31 from codewithme-py/feat/bug-fixes

feat: implement flexible user authentication, harden product moderation logic, and improve S3 presigned URL generation with host substitution.

Author: codewithme-py

.dockerignore

@@ -3,4 +3,5 @@ __pycache__
 .git
 .pytest_cache
 .mypy_cache
-.ruff_cache
+.ruff_cache
+.qwen/

.env

@@ -14,8 +14,9 @@ S3_HOST=s3-fairdrop
 S3_PORT=9000
 MINIO_ROOT_USER=s3_fairdrop_user
 MINIO_ROOT_PASSWORD=s3_fairdrop_password
-MINIO_BUCKET_NAME=s3_fairdrop-media
+MINIO_BUCKET_NAME=fairdrop-media
 MINIO_URL=http://${S3_HOST}:${S3_PORT}
+S3_PUBLIC_URL=http://localhost:9000
 PRESIGNED_URL_EXPIRE_SECONDS=3600
 MIN_FILE_SIZE_BYTES=1
 MAX_FILE_SIZE_BYTES=5242880

.gitignore

@@ -17,4 +17,5 @@ wheels/
 .vscode/
 
 # Local env
-.coverage
+.coverage
+.qwen/

app/core/auth_schemes.py

@@ -1,4 +1,7 @@
 from fastapi.security import APIKeyHeader, OAuth2PasswordBearer
 
 oauth2_scheme = OAuth2PasswordBearer(tokenUrl='/api/v1/auth/token')
+oauth2_scheme_optional = OAuth2PasswordBearer(
+    tokenUrl='/api/v1/auth/token', auto_error=False
+)
 header_scheme = APIKeyHeader(name='X-API-Key', auto_error=False)

app/core/config.py

@@ -20,6 +20,7 @@ class Settings(BaseSettings):
     minio_root_password: str = Field(alias='MINIO_ROOT_PASSWORD')
     minio_bucket_name: str = Field(alias='MINIO_BUCKET_NAME')
     minio_url: str = Field(alias='MINIO_URL')
+    s3_public_url: str = Field(alias='S3_PUBLIC_URL')
     pool_size: int = Field(alias='POOL_SIZE')
     max_overflow: int = Field(alias='MAX_OVERFLOW')
     jwt_algorithm: str = Field(default='HS256', alias='JWT_ALGORITHM')

app/core/s3.py

@@ -4,28 +4,33 @@
 
 import aioboto3  # type: ignore
 import structlog
+from botocore.config import Config
 from botocore.exceptions import ClientError
 
 from app.core.config import settings
 
 logger = structlog.get_logger(__name__)
 
 session = aioboto3.Session()
+s3_config = Config(s3={'addressing_style': 'path'})
 
 
-@asynccontextmanager
-async def get_s3_client() -> AsyncIterator[Any]:
+async def get_s3_client_gen() -> AsyncIterator[Any]:
     async with session.client(
         's3',
         endpoint_url=settings.minio_url,
         region_name='us-east-1',
         aws_access_key_id=settings.minio_root_user,
         aws_secret_access_key=settings.minio_root_password,
         verify=False,
+        config=s3_config,
     ) as client:
         yield client
 
 
+get_s3_client = asynccontextmanager(get_s3_client_gen)
+
+
 async def init_s3_bucket() -> None:
     async with session.client(
         's3',
@@ -34,13 +39,14 @@ async def init_s3_bucket() -> None:
         aws_access_key_id=settings.minio_root_user,
         aws_secret_access_key=settings.minio_root_password,
         verify=False,
+        config=s3_config,
     ) as client:
         try:
             await client.head_bucket(Bucket=settings.minio_bucket_name)
             logger.info(f'Bucket {settings.minio_bucket_name} already exists')
         except ClientError as e:
             if e.response['Error']['Code'] == '404':
-                await client.make_bucket(Bucket=settings.minio_bucket_name)
+                await client.create_bucket(Bucket=settings.minio_bucket_name)
                 logger.info(f'Bucket {settings.minio_bucket_name} created')
             else:
                 logger.error(e)

app/services/inventory/routes.py

@@ -1,10 +1,11 @@
-from typing import Annotated
+from typing import Annotated, Any
 from uuid import UUID
 
 from fastapi import APIRouter, Depends, Header, Query, Request, status
 
 from app.core.config import settings
 from app.core.database import SessionDep
+from app.core.s3 import get_s3_client_gen
 from app.core.security import RoleChecker, UserRole
 from app.services.inventory.models import ProductStatus
 from app.services.inventory.schemas import (
@@ -15,6 +16,7 @@
     ReservationResponse,
 )
 from app.services.inventory.service import InventoryAdminService, InventoryService
+from app.services.media.service import generate_presigned_get_url
 from app.services.user.models import User
 from app.shared.decorators import idempotent
 from app.shared.deps import get_current_user
@@ -50,10 +52,24 @@
 )
 
 
+async def _enrich_product_images(product: Any, s3_client: Any) -> ProductRead:
+    """Helper to generate presigned URLs for product images."""
+    read_obj = ProductRead.model_validate(product)
+    image_urls = []
+    if hasattr(product, 'images'):
+        for img in product.images:
+            if img.status == 'active':
+                url = await generate_presigned_get_url(s3_client, img.file_path)
+                image_urls.append(url)
+    read_obj.image_urls = image_urls
+    return read_obj
+
+
 @router_v1.get('/', response_model=list[ProductRead])
 async def get_active_products(
     session: SessionDep,
     service: Annotated[InventoryService, Depends(get_inventory_service)],
+    s3_client: Any = Depends(get_s3_client_gen),
     skip: int = 0,
     limit: int = 50,
 ) -> list[ProductRead]:
@@ -63,7 +79,7 @@ async def get_active_products(
         limit=limit,
         session=session,
     )
-    return [ProductRead.model_validate(p) for p in products]
+    return [await _enrich_product_images(p, s3_client) for p in products]
 
 
 @router_v1.post('/', response_model=ProductRead, status_code=status.HTTP_201_CREATED)
@@ -134,12 +150,13 @@ async def get_product(
     product_id: UUID,
     session: SessionDep,
     service: Annotated[InventoryService, Depends(get_inventory_service)],
+    s3_client: Any = Depends(get_s3_client_gen),
 ) -> ProductRead:
     product = await service.get_product(
         session=session,
         product_id=product_id,
     )
-    return ProductRead.model_validate(product)
+    return await _enrich_product_images(product, s3_client)
 
 
 @router_v1.post('/reserve', response_model=ReservationResponse)

app/services/inventory/schemas.py

@@ -37,6 +37,7 @@ class ProductRead(BaseModel):
     status: ProductStatus
     created_at: datetime
     updated_at: datetime
+    image_urls: list[str] = []
 
 
 class ReservationCreate(BaseModel):

app/services/inventory/service.py

@@ -5,6 +5,7 @@
 from sqlalchemy import select
 from sqlalchemy.exc import IntegrityError
 from sqlalchemy.ext.asyncio import AsyncSession
+from sqlalchemy.orm import joinedload
 
 from app.core.audit_log.service import audit_log_service
 from app.core.config import settings
@@ -53,8 +54,10 @@ async def _get_product(
         query = select(Product).where(Product.id == product_id)
         if for_update:
             query = query.with_for_update()
+        else:
+            query = query.options(joinedload(Product.images))
         result = await session.execute(query)
-        product = result.scalar_one_or_none()
+        product = result.unique().scalar_one_or_none()
         if not product:
             raise NotFoundError
         if current_user:
@@ -142,9 +145,17 @@ async def update_product(
         product = await InventoryService._get_product(
             session, product_id, for_update=True, current_user=current_user
         )
+        if product.status in (
+            ProductStatus.PENDING_MODERATION,
+            ProductStatus.MODERATION_IN_PROGRESS,
+        ):
+            raise ConflictError('Cannot edit product while it is under moderation')
         old_snapshot = ProductRead.model_validate(product)
         for field, value in product_data.model_dump(exclude_unset=True).items():
             setattr(product, field, value)
+        if product.status == ProductStatus.ACTIVE:
+            product.status = ProductStatus.PENDING_MODERATION
+            product.moderator_id = None
         await InventoryService._log_product_change(
             session=session,
             user=current_user,
@@ -187,11 +198,11 @@ async def get_products(
         skip: int = 0,
         limit: int = 50,
     ) -> list[Product]:
-        query = select(Product)
+        query = select(Product).options(joinedload(Product.images))
         if status:
             query = query.where(Product.status == status)
         result = await session.execute(query.offset(skip).limit(limit))
-        return list(result.scalars().all())
+        return list(result.scalars().unique().all())
 
     @staticmethod
     async def reserve_items(

app/services/media/routes.py

@@ -8,7 +8,7 @@
 
 from app.core.audit_log.service import audit_log_service
 from app.core.database import get_session
-from app.core.s3 import get_s3_client
+from app.core.s3 import get_s3_client_gen
 from app.services.media.schemas import (
     ImageUploadRequest,
     ImageUploadResponse,
@@ -21,7 +21,7 @@
     handle_minio_webhook,
 )
 from app.services.user.models import User, UserRole
-from app.shared.deps import get_current_user
+from app.shared.deps import get_current_user, get_current_user_flexible
 
 router_v1 = APIRouter(prefix='/media', tags=['Media'])
 
@@ -31,7 +31,7 @@ async def create_upload_url(
     product_id: UUID,
     req: ImageUploadRequest,
     session: AsyncSession = Depends(get_session),
-    s3_client: Any = Depends(get_s3_client),
+    s3_client: Any = Depends(get_s3_client_gen),
     current_user: User = Depends(get_current_user),
 ) -> ImageUploadResponse:
     return await generate_upload_url(session, s3_client, product_id, req)
@@ -53,8 +53,8 @@ async def view_private_file(
     target_id: UUID,
     doc_key: str | None = None,
     session: AsyncSession = Depends(get_session),
-    s3_client: Any = Depends(get_s3_client),
-    current_user: User = Depends(get_current_user),
+    s3_client: Any = Depends(get_s3_client_gen),
+    current_user: User = Depends(get_current_user_flexible),
 ) -> RedirectResponse:
     if current_user.role not in (UserRole.ADMIN, UserRole.MODERATOR):
         raise HTTPException(