Skip to content

Commit 7ae7067

Browse files
committed
Preserve null in project update for taskManager
Adjusts mock project update logic to correctly preserve null values for taskManager when explicitly set, ensuring accurate test behavior for scenarios like disconnectTaskManager. Also refactors test setup in GitHub routes integration test for clarity.
1 parent 805daab commit 7ae7067

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

test/integrations/github-routes.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,8 +681,8 @@ describe('GitHub Routes - /integration/github/connect', () => {
681681
workspaceId,
682682
});
683683
mockProject.taskManager = null;
684+
mockProject.updateProject = jest.fn().mockResolvedValue(undefined);
684685
mockGetInstallationForRepository.mockResolvedValue({});
685-
mockProject.updateProject.mockResolvedValue(undefined);
686686

687687
const factories: ContextFactories = {
688688
projectsFactory: {

test/resolvers/project.test.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,12 @@ function createMockProject(options: {
5151
const mockUpdateProject = jest.fn().mockImplementation(async (data) => {
5252
/**
5353
* Return updated project with new data
54+
* Preserve null when explicitly passed (e.g. disconnectTaskManager sets taskManager: null)
5455
*/
56+
const nextTaskManager = data.taskManager !== undefined
57+
? data.taskManager
58+
: (taskManager ?? undefined);
59+
5560
return {
5661
_id: new ObjectId(projectId),
5762
workspaceId: new ObjectId(workspaceId),
@@ -60,7 +65,7 @@ function createMockProject(options: {
6065
token: 'test-token',
6166
notifications: [],
6267
eventGroupingPatterns: [],
63-
taskManager: data.taskManager !== undefined ? (data.taskManager ?? undefined) : (taskManager ?? undefined),
68+
taskManager: nextTaskManager,
6469
};
6570
});
6671

0 commit comments

Comments
 (0)